Require parameters in ECPrivateKey for Composite ML-DSA #120601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Composite ML-DSA implementation to comply with Draft 12 of the specification, which now requires parameters to be present in ECPrivateKey structures. The key change is that ECPrivateKey objects must now include curve parameters (OID) for composite ML-DSA algorithms.
- Updates ECPrivateKey generation to include required curve parameters
- Modifies validation logic to enforce parameter presence and correctness
- Updates size calculations to account for the additional parameter data
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| CompositeMLDsaManaged.cs | Updates draft specification references from version 08 to 12 |
| CompositeMLDsaManaged.ECDsa.cs | Adds parameter validation and generation for ECPrivateKey structures |
| CompositeMLDsaAlgorithm.cs | Updates size calculations to include parameter overhead |
| CompositeMLDsaTestHelpers.cs | Updates expected key size calculations with specific values per algorithm |
| CompositeMLDsaFactoryTests.cs | Updates test cases to reflect new parameter requirements and validation |
src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaAlgorithm.cs
Show resolved
Hide resolved
...m/Security/Cryptography/AlgorithmImplementations/CompositeMLDsa/CompositeMLDsaTestHelpers.cs
Show resolved
Hide resolved
vcsjones
reviewed
Oct 14, 2025
src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaManaged.ECDsa.cs
Outdated
Show resolved
Hide resolved
.../Security/Cryptography/AlgorithmImplementations/CompositeMLDsa/CompositeMLDsaFactoryTests.cs
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaManaged.ECDsa.cs
Show resolved
Hide resolved
…eMLDsaManaged.ECDsa.cs Co-authored-by: Kevin Jones <vcsjones@github.com>
…an/runtime into cmldsa-draft11
PranavSenthilnathan
added
the
breaking-change
|
No APIs changed but, following our past convention, implementing an updated PQC draft requires a breaking change doc. Assuming we get this in for .NET 10, we can just modify dotnet/docs#48901. |
dotnet-policy-service
bot
added
the
needs-breaking-change-doc-created
|
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
bartonjs
approved these changes
Oct 20, 2025
|
/ba-g #103347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft 12 of the Composite ML-DSA spec now requires the parameters to be present for
ECPrivateKey. This PR implements these changes in our managed Composite ML-DSA implementation.