-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Updated Tensorflow.Net to 0.70.2 with Tensorflow 2.7.0. #7472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Crichen
wants to merge
17
commits into
dotnet:main
Choose a base branch
from
Crichen:update-tensorflow-issue-7471
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
82e3275
Updated Tensorflow.Net to 0.70.2 with Tensorflow 2.7.0.
RossHNPC 16782f6
Common code to ArrayUtils, dotnet added to Sdk install to resolve CI …
RossHNPC 85f7ad4
Temporarily omit GPU packages
ericstj 02419b8
Removing installation of .NET 9.0
ericstj 17bf4cc
Update TensorFlow.NET to 0.150.0
ericstj 7e5d791
Rollback TensorFlow.NET to 0.110.1 to workaround strong name signing …
ericstj 1da1a6f
Rollback TensorFlow.Net to 0.100.4
ericstj 82e8a64
Rollback TensorFlow.Net to 0.100.2
ericstj f350740
Use different version for TensorFlow GPU packages
ericstj bb5c00c
Remove VectorDataViewType overload that accepts long[]
ericstj eada7a0
Merge branch 'main' of https://github.com/dotnet/machinelearning into…
ericstj 734b8d1
Update Microsoft.ML.Samples.GPU.csproj
ericstj 3a4df1e
Workaround build error from TF-GPU package
ericstj 1089633
Update src/Microsoft.ML.TensorFlow/TensorflowTransform.cs
ericstj 7562205
Avoid finalizer crash in tests
ericstj 822e26a
Merge branch 'update-tensorflow-issue-7471' of https://github.com/Cri…
ericstj e99dcc1
Fix a couple more missing dispose
ericstj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this version and not latest (
0.150.01
)? Was there an issue with the latest package?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a time critical update and we needed to get to a version that could be deployed without requiring WSL support to enable full use of the GPU. I believe that 0.100.x releases still works without WSL but it seemed quite a big jump to go from 0.70.x and to jump Tensorflow from 2.7 to 2.10. We could investigate though to see if there are any breaking changes involved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we should be on the latest supported so that we ensure we can take any future updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran into issues going all the way to the latest TensorFlow.NET. I was able to absorb the breaking API changes, but they removal of strong name signing as well as taking on a dependency without a strong name will break consumption on .NETFramework. I filed SciSharp/TensorFlow.NET#1296 to track those.
I rolled back to a version without those breaks, hit one other break around disposal of status, and rolled back further to 0.100.2.
I think this is the latest version that will still work and it's just one release ahead of what you were using 🙃