Skip to content

Commit 0e89dd0

Browse files
committed
Get rid of DateTimeDateFrameColumn alias
1 parent 28f63f0 commit 0e89dd0

File tree

3 files changed

+4
-27
lines changed

3 files changed

+4
-27
lines changed

src/Microsoft.Data.Analysis/DateTimeDataFrameColumn.cs

Lines changed: 0 additions & 23 deletions
This file was deleted.

src/Microsoft.Data.Analysis/IDataView.Extension.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public static DataFrame ToDataFrame(this IDataView dataView, long maxRows, param
7070
}
7171
else if (type == DateTimeDataViewType.Instance)
7272
{
73-
dataFrameColumns.Add(new DateTimeDataFrameColumn(dataViewColumn.Name));
73+
dataFrameColumns.Add(new PrimitiveDataFrameColumn<DateTime>(dataViewColumn.Name));
7474
}
7575
else if (type == NumberDataViewType.Byte)
7676
{

test/Microsoft.Data.Analysis.Tests/DataFrameTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ public static DataFrame MakeDataFrameWithNumericStringAndDateTimeColumns(int len
148148
{
149149
DataFrame df = MakeDataFrameWithNumericAndStringColumns(length, withNulls);
150150

151-
DataFrameColumn dateTimeColumn = new DateTimeDataFrameColumn("DateTime", Enumerable.Range(0, length).Select(x => SampleDateTime.AddDays(x)));
151+
DataFrameColumn dateTimeColumn = new PrimitiveDataFrameColumn<DateTime>("DateTime", Enumerable.Range(0, length).Select(x => SampleDateTime.AddDays(x)));
152152
df.Columns.Insert(df.Columns.Count, dateTimeColumn);
153153
if (withNulls)
154154
{
@@ -497,9 +497,9 @@ public void TestBinaryOperationsOnBoolColumn()
497497
public void TestBinaryOperationsOnDateTimeColumn()
498498
{
499499
var df = new DataFrame();
500-
var dataFrameColumn1 = new DateTimeDataFrameColumn("DateTime1", Enumerable.Range(0, 5).Select(x => SampleDateTime.AddDays(x)));
500+
var dataFrameColumn1 = new PrimitiveDataFrameColumn<DateTime>("DateTime1", Enumerable.Range(0, 5).Select(x => SampleDateTime.AddDays(x)));
501501
// Make the second data frame column have one value that is different
502-
var dataFrameColumn2 = new DateTimeDataFrameColumn("DateTime2", Enumerable.Range(0, 4).Select(x => SampleDateTime.AddDays(x)));
502+
var dataFrameColumn2 = new PrimitiveDataFrameColumn<DateTime>("DateTime2", Enumerable.Range(0, 4).Select(x => SampleDateTime.AddDays(x)));
503503
dataFrameColumn2.Append(SampleDateTime.AddDays(6));
504504
df.Columns.Insert(0, dataFrameColumn1);
505505
df.Columns.Insert(1, dataFrameColumn2);

0 commit comments

Comments
 (0)