Skip to content

Commit 28f63f0

Browse files
committed
Remove the alias types for now and get all tests pass.
1 parent c4d2999 commit 28f63f0

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+1272
-28357
lines changed

src/Microsoft.Data.Analysis/BooleanDataFrameColumn.cs

Lines changed: 0 additions & 23 deletions
This file was deleted.

src/Microsoft.Data.Analysis/ByteDataFrameColumn.cs

Lines changed: 0 additions & 23 deletions
This file was deleted.

src/Microsoft.Data.Analysis/CharDataFrameColumn.cs

Lines changed: 0 additions & 23 deletions
This file was deleted.

src/Microsoft.Data.Analysis/DataFrame.Arrow.cs

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -22,43 +22,43 @@ private static void AppendDataFrameColumnFromArrowArray(Field field, IArrowArray
2222
BooleanArray arrowBooleanArray = (BooleanArray)arrowArray;
2323
ReadOnlyMemory<byte> valueBuffer = arrowBooleanArray.ValueBuffer.Memory;
2424
ReadOnlyMemory<byte> nullBitMapBuffer = arrowBooleanArray.NullBitmapBuffer.Memory;
25-
dataFrameColumn = new BooleanDataFrameColumn(fieldName, valueBuffer, nullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
25+
dataFrameColumn = new PrimitiveDataFrameColumn<bool>(fieldName, valueBuffer, nullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
2626
break;
2727
case ArrowTypeId.Double:
2828
PrimitiveArray<double> arrowDoubleArray = (PrimitiveArray<double>)arrowArray;
2929
ReadOnlyMemory<byte> doubleValueBuffer = arrowDoubleArray.ValueBuffer.Memory;
3030
ReadOnlyMemory<byte> doubleNullBitMapBuffer = arrowDoubleArray.NullBitmapBuffer.Memory;
31-
dataFrameColumn = new DoubleDataFrameColumn(fieldName, doubleValueBuffer, doubleNullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
31+
dataFrameColumn = new PrimitiveDataFrameColumn<double>(fieldName, doubleValueBuffer, doubleNullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
3232
break;
3333
case ArrowTypeId.Float:
3434
PrimitiveArray<float> arrowFloatArray = (PrimitiveArray<float>)arrowArray;
3535
ReadOnlyMemory<byte> floatValueBuffer = arrowFloatArray.ValueBuffer.Memory;
3636
ReadOnlyMemory<byte> floatNullBitMapBuffer = arrowFloatArray.NullBitmapBuffer.Memory;
37-
dataFrameColumn = new SingleDataFrameColumn(fieldName, floatValueBuffer, floatNullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
37+
dataFrameColumn = new PrimitiveDataFrameColumn<float>(fieldName, floatValueBuffer, floatNullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
3838
break;
3939
case ArrowTypeId.Int8:
4040
PrimitiveArray<sbyte> arrowsbyteArray = (PrimitiveArray<sbyte>)arrowArray;
4141
ReadOnlyMemory<byte> sbyteValueBuffer = arrowsbyteArray.ValueBuffer.Memory;
4242
ReadOnlyMemory<byte> sbyteNullBitMapBuffer = arrowsbyteArray.NullBitmapBuffer.Memory;
43-
dataFrameColumn = new SByteDataFrameColumn(fieldName, sbyteValueBuffer, sbyteNullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
43+
dataFrameColumn = new PrimitiveDataFrameColumn<sbyte>(fieldName, sbyteValueBuffer, sbyteNullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
4444
break;
4545
case ArrowTypeId.Int16:
4646
PrimitiveArray<short> arrowshortArray = (PrimitiveArray<short>)arrowArray;
4747
ReadOnlyMemory<byte> shortValueBuffer = arrowshortArray.ValueBuffer.Memory;
4848
ReadOnlyMemory<byte> shortNullBitMapBuffer = arrowshortArray.NullBitmapBuffer.Memory;
49-
dataFrameColumn = new Int16DataFrameColumn(fieldName, shortValueBuffer, shortNullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
49+
dataFrameColumn = new PrimitiveDataFrameColumn<short>(fieldName, shortValueBuffer, shortNullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
5050
break;
5151
case ArrowTypeId.Int32:
5252
PrimitiveArray<int> arrowIntArray = (PrimitiveArray<int>)arrowArray;
5353
ReadOnlyMemory<byte> intValueBuffer = arrowIntArray.ValueBuffer.Memory;
5454
ReadOnlyMemory<byte> intNullBitMapBuffer = arrowIntArray.NullBitmapBuffer.Memory;
55-
dataFrameColumn = new Int32DataFrameColumn(fieldName, intValueBuffer, intNullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
55+
dataFrameColumn = new PrimitiveDataFrameColumn<int>(fieldName, intValueBuffer, intNullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
5656
break;
5757
case ArrowTypeId.Int64:
5858
PrimitiveArray<long> arrowLongArray = (PrimitiveArray<long>)arrowArray;
5959
ReadOnlyMemory<byte> longValueBuffer = arrowLongArray.ValueBuffer.Memory;
6060
ReadOnlyMemory<byte> longNullBitMapBuffer = arrowLongArray.NullBitmapBuffer.Memory;
61-
dataFrameColumn = new Int64DataFrameColumn(fieldName, longValueBuffer, longNullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
61+
dataFrameColumn = new PrimitiveDataFrameColumn<long>(fieldName, longValueBuffer, longNullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
6262
break;
6363
case ArrowTypeId.String:
6464
StringArray stringArray = (StringArray)arrowArray;
@@ -71,25 +71,25 @@ private static void AppendDataFrameColumnFromArrowArray(Field field, IArrowArray
7171
PrimitiveArray<byte> arrowbyteArray = (PrimitiveArray<byte>)arrowArray;
7272
ReadOnlyMemory<byte> byteValueBuffer = arrowbyteArray.ValueBuffer.Memory;
7373
ReadOnlyMemory<byte> byteNullBitMapBuffer = arrowbyteArray.NullBitmapBuffer.Memory;
74-
dataFrameColumn = new ByteDataFrameColumn(fieldName, byteValueBuffer, byteNullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
74+
dataFrameColumn = new PrimitiveDataFrameColumn<byte>(fieldName, byteValueBuffer, byteNullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
7575
break;
7676
case ArrowTypeId.UInt16:
7777
PrimitiveArray<ushort> arrowUshortArray = (PrimitiveArray<ushort>)arrowArray;
7878
ReadOnlyMemory<byte> ushortValueBuffer = arrowUshortArray.ValueBuffer.Memory;
7979
ReadOnlyMemory<byte> ushortNullBitMapBuffer = arrowUshortArray.NullBitmapBuffer.Memory;
80-
dataFrameColumn = new UInt16DataFrameColumn(fieldName, ushortValueBuffer, ushortNullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
80+
dataFrameColumn = new PrimitiveDataFrameColumn<ushort>(fieldName, ushortValueBuffer, ushortNullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
8181
break;
8282
case ArrowTypeId.UInt32:
8383
PrimitiveArray<uint> arrowUintArray = (PrimitiveArray<uint>)arrowArray;
8484
ReadOnlyMemory<byte> uintValueBuffer = arrowUintArray.ValueBuffer.Memory;
8585
ReadOnlyMemory<byte> uintNullBitMapBuffer = arrowUintArray.NullBitmapBuffer.Memory;
86-
dataFrameColumn = new UInt32DataFrameColumn(fieldName, uintValueBuffer, uintNullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
86+
dataFrameColumn = new PrimitiveDataFrameColumn<uint>(fieldName, uintValueBuffer, uintNullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
8787
break;
8888
case ArrowTypeId.UInt64:
8989
PrimitiveArray<ulong> arrowUlongArray = (PrimitiveArray<ulong>)arrowArray;
9090
ReadOnlyMemory<byte> ulongValueBuffer = arrowUlongArray.ValueBuffer.Memory;
9191
ReadOnlyMemory<byte> ulongNullBitMapBuffer = arrowUlongArray.NullBitmapBuffer.Memory;
92-
dataFrameColumn = new UInt64DataFrameColumn(fieldName, ulongValueBuffer, ulongNullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
92+
dataFrameColumn = new PrimitiveDataFrameColumn<ulong>(fieldName, ulongValueBuffer, ulongNullBitMapBuffer, arrowArray.Length, arrowArray.NullCount);
9393
break;
9494
case ArrowTypeId.Struct:
9595
StructArray structArray = (StructArray)arrowArray;

src/Microsoft.Data.Analysis/DataFrame.IO.cs

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -131,59 +131,59 @@ private static DataFrameColumn CreateColumn(Type kind, string[] columnNames, int
131131
DataFrameColumn ret;
132132
if (kind == typeof(bool))
133133
{
134-
ret = new BooleanDataFrameColumn(GetColumnName(columnNames, columnIndex));
134+
ret = new PrimitiveDataFrameColumn<bool>(GetColumnName(columnNames, columnIndex));
135135
}
136136
else if (kind == typeof(int))
137137
{
138-
ret = new Int32DataFrameColumn(GetColumnName(columnNames, columnIndex));
138+
ret = new PrimitiveDataFrameColumn<int>(GetColumnName(columnNames, columnIndex));
139139
}
140140
else if (kind == typeof(float))
141141
{
142-
ret = new SingleDataFrameColumn(GetColumnName(columnNames, columnIndex));
142+
ret = new PrimitiveDataFrameColumn<float>(GetColumnName(columnNames, columnIndex));
143143
}
144144
else if (kind == typeof(string))
145145
{
146146
ret = new StringDataFrameColumn(GetColumnName(columnNames, columnIndex), 0);
147147
}
148148
else if (kind == typeof(long))
149149
{
150-
ret = new Int64DataFrameColumn(GetColumnName(columnNames, columnIndex));
150+
ret = new PrimitiveDataFrameColumn<long>(GetColumnName(columnNames, columnIndex));
151151
}
152152
else if (kind == typeof(decimal))
153153
{
154-
ret = new DecimalDataFrameColumn(GetColumnName(columnNames, columnIndex));
154+
ret = new PrimitiveDataFrameColumn<decimal>(GetColumnName(columnNames, columnIndex));
155155
}
156156
else if (kind == typeof(byte))
157157
{
158-
ret = new ByteDataFrameColumn(GetColumnName(columnNames, columnIndex));
158+
ret = new PrimitiveDataFrameColumn<byte>(GetColumnName(columnNames, columnIndex));
159159
}
160160
else if (kind == typeof(char))
161161
{
162-
ret = new CharDataFrameColumn(GetColumnName(columnNames, columnIndex));
162+
ret = new PrimitiveDataFrameColumn<char>(GetColumnName(columnNames, columnIndex));
163163
}
164164
else if (kind == typeof(double))
165165
{
166-
ret = new DoubleDataFrameColumn(GetColumnName(columnNames, columnIndex));
166+
ret = new PrimitiveDataFrameColumn<double>(GetColumnName(columnNames, columnIndex));
167167
}
168168
else if (kind == typeof(sbyte))
169169
{
170-
ret = new SByteDataFrameColumn(GetColumnName(columnNames, columnIndex));
170+
ret = new PrimitiveDataFrameColumn<sbyte>(GetColumnName(columnNames, columnIndex));
171171
}
172172
else if (kind == typeof(short))
173173
{
174-
ret = new Int16DataFrameColumn(GetColumnName(columnNames, columnIndex));
174+
ret = new PrimitiveDataFrameColumn<short>(GetColumnName(columnNames, columnIndex));
175175
}
176176
else if (kind == typeof(uint))
177177
{
178-
ret = new UInt32DataFrameColumn(GetColumnName(columnNames, columnIndex));
178+
ret = new PrimitiveDataFrameColumn<uint>(GetColumnName(columnNames, columnIndex));
179179
}
180180
else if (kind == typeof(ulong))
181181
{
182-
ret = new UInt64DataFrameColumn(GetColumnName(columnNames, columnIndex));
182+
ret = new PrimitiveDataFrameColumn<ulong>(GetColumnName(columnNames, columnIndex));
183183
}
184184
else if (kind == typeof(ushort))
185185
{
186-
ret = new UInt16DataFrameColumn(GetColumnName(columnNames, columnIndex));
186+
ret = new PrimitiveDataFrameColumn<ushort>(GetColumnName(columnNames, columnIndex));
187187
}
188188
else if (kind == typeof(DateTime))
189189
{

src/Microsoft.Data.Analysis/DataFrame.Join.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ private static Dictionary<long, ICollection<long>> GetOccurences(DataFrame retai
221221

222222
retainedIndicesReverseMapping = newRetainedIndicesReverseMapping;
223223

224-
var indices = new Int64DataFrameColumn("Indices", shrinkedRetainedIndices);
224+
var indices = new PrimitiveDataFrameColumn<long>("Indices", shrinkedRetainedIndices);
225225
shrinkedRetainedColumn = shrinkedRetainedColumn.Clone(indices);
226226
}
227227

@@ -277,8 +277,8 @@ private static HashSet<long> PerformMerging(DataFrame retainedDataFrame, string[
277277
out PrimitiveDataFrameColumn<long> retainedRowIndices, out PrimitiveDataFrameColumn<long> supplementaryRowIndices,
278278
bool isInner, bool calculateIntersection)
279279
{
280-
retainedRowIndices = new Int64DataFrameColumn("RetainedIndices");
281-
supplementaryRowIndices = new Int64DataFrameColumn("SupplementaryIndices");
280+
retainedRowIndices = new PrimitiveDataFrameColumn<long>("RetainedIndices");
281+
supplementaryRowIndices = new PrimitiveDataFrameColumn<long>("SupplementaryIndices");
282282

283283
HashSet<long> intersection = calculateIntersection ? new HashSet<long>() : null;
284284

src/Microsoft.Data.Analysis/DataFrame.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -643,7 +643,7 @@ private void OnColumnsChanged()
643643
private DataFrame Sort(string columnName, bool isAscending)
644644
{
645645
DataFrameColumn column = Columns[columnName];
646-
PrimitiveDataFrameColumn<long> sortIndices = column.GetAscendingSortIndices(out Int64DataFrameColumn nullIndices);
646+
PrimitiveDataFrameColumn<long> sortIndices = column.GetAscendingSortIndices(out PrimitiveDataFrameColumn<long> nullIndices);
647647
for (long i = 0; i < nullIndices.Length; i++)
648648
{
649649
sortIndices.Append(nullIndices[i]);

src/Microsoft.Data.Analysis/DataFrameColumn.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ public object this[long rowIndex]
199199
/// <param name="ascending"></param>
200200
public virtual DataFrameColumn Sort(bool ascending = true)
201201
{
202-
PrimitiveDataFrameColumn<long> sortIndices = GetAscendingSortIndices(out Int64DataFrameColumn _);
202+
PrimitiveDataFrameColumn<long> sortIndices = GetAscendingSortIndices(out PrimitiveDataFrameColumn<long> _);
203203
return Clone(sortIndices, !ascending, NullCount);
204204
}
205205

@@ -378,7 +378,7 @@ public virtual StringDataFrameColumn Info()
378378
/// Returns the indices of non-null values that, when applied, result in this column being sorted in ascending order. Also returns the indices of null values in <paramref name="nullIndices"/>.
379379
/// </summary>
380380
/// <param name="nullIndices">Indices of values that are <see langword="null"/>.</param>
381-
internal virtual PrimitiveDataFrameColumn<long> GetAscendingSortIndices(out Int64DataFrameColumn nullIndices) => throw new NotImplementedException();
381+
internal virtual PrimitiveDataFrameColumn<long> GetAscendingSortIndices(out PrimitiveDataFrameColumn<long> nullIndices) => throw new NotImplementedException();
382382

383383
internal delegate long GetBufferSortIndex(int bufferIndex, int sortIndex);
384384
internal delegate ValueTuple<T, int> GetValueAndBufferSortIndexAtBuffer<T>(int bufferIndex, int valueIndex);

0 commit comments

Comments
 (0)