Clarify that using global.json may not be rare #44667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the word choice for using global.json to select the SDK. The previous word choice made it sound like using a global.json wasn't recommended and reserved for "rare" situations. In practice, many teams want reproducible builds, and as such need to pin developers to a specific version. To address the concern that global.json can lead to pinning old versions of the SDK, I added a new section calling out that devs can use tools like `dotnet sdk check` and Dependabot to manage SDK updates.
dotnet-policy-service
bot
added
dotnet-fundamentals/svc
community-contribution
|
/cc @baronfel for FYI as someone interested in both SDK and reproducible builds |
BillWagner
reviewed
Feb 4, 2025
There was a problem hiding this comment.
Thanks @MattKotsenas
This looks great, except for one sentence I found very hard to parse. Check my suggestion, and once that's corrected, this is ready to merge.
Reviewed at commit 1.
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
BillWagner
approved these changes
Feb 5, 2025
now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the word choice for using global.json to select the SDK. The previous word choice made it sound like using a global.json wasn't recommended and reserved for "rare" situations. In practice, many teams want reproducible builds, and as such need to pin developers to a specific version.
To address the concern that global.json can lead to pinning old versions of the SDK, I added a new section calling out that devs can use tools like
dotnet sdk checkand Dependabot to manage SDK updates.Internal previews