Skip to content

Freshness pass on LINQ content #44410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 17, 2025
Merged

Freshness pass on LINQ content #44410

merged 4 commits into from
Jan 17, 2025

Conversation

BillWagner
Copy link
Member

@BillWagner BillWagner commented Jan 16, 2025 •
edited by github-actions bot
Loading

Address some questions about the data sources on the get started with LINQ samples. This may be easier to review commit-by-commit:

  1. Fix all open issues:
  1. Review and update code: Hide whitespace for this commit. It's mostly formatting changes.
  2. Edit pass on the affected articles.

Internal previews

📄 File 🔗 Preview link
docs/csharp/linq/get-started/query-expression-basics.md Query expression basics
docs/csharp/linq/get-started/write-linq-queries.md Write LINQ queries

@BillWagner
Fix open issues
e9e5b2e 
- Fixes dotnet#43760: Update where clause to filter out some values. Update output comment.
- Fixes dotnet#43765:  Update `let` statement so the query result isn't empty.
- Fixes dotnet#43766: Update query parameters so the result set isn't empty.
- Fixes dotnet#43768: Add sample data
- Fixes dotnet#43790: Audit all samples in this article and ensure all have output.
- Fixes dotnet#43809:  Update samples to include the data sources.

While doing this, update the project to .NET 9
@dotnetrepoman dotnetrepoman bot added this to the January 2025 milestone Jan 16, 2025
@dotnet-policy-service dotnet-policy-service bot added okr-freshness OKR: Freshness of content okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. dotnet-csharp/svc csharp-linq/subsvc labels Jan 16, 2025
@BillWagner
Review and update code.
2f2fb74 
Hide whitespace for this commit. It's mostly formatting changes.
@BillWagner
Edit pass.
f43e8a2 
Grammar and edit pass.
@BillWagner BillWagner marked this pull request as ready for review January 16, 2025 20:40
@BillWagner BillWagner requested a review from a team as a code owner January 16, 2025 20:40
@BillWagner BillWagner requested a review from gewarren January 16, 2025 20:40
gewarren
gewarren approved these changes Jan 17, 2025
View reviewed changes
@BillWagner @gewarren
Apply suggestions from code review
608ff48 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@BillWagner BillWagner enabled auto-merge (squash) January 17, 2025 20:13
@BillWagner BillWagner merged commit c887106 into dotnet:main Jan 17, 2025
8 checks passed
@BillWagner BillWagner deleted the fresh-as-linq branch January 17, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

Assignees
No one assigned
Labels
csharp-linq/subsvc dotnet-csharp/svc okr-freshness OKR: Freshness of content okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.

Missing Data Missing Data No results are returned Example returns no data Incorrect Output
Missing Data
2 participants
@BillWagner @gewarren