Skip to content

Fix typos in Update custom-resources.md #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2024

Conversation

DamianEdwards
Copy link
Member

@DamianEdwards DamianEdwards commented May 17, 2024

Fixes some minor issues in the custom resources doc observed while watching https://www.youtube.com/watch?v=4rVrR9haWlg

Summary

Describe your changes here.

Fixes #Issue_Number (if available)


Internal previews

📄 File 🔗 Preview link
docs/extensibility/custom-resources.md Create custom resource types for .NET Aspire

Fixes some minor issues in the custom resources doc observed while watching https://www.youtube.com/watch?v=4rVrR9haWlg
@DamianEdwards DamianEdwards requested review from mitchdenny and IEvangelist and removed request for IEvangelist May 17, 2024 18:40
@IEvangelist
Copy link
Member

Thank you so much for your video @peterj, it was really helpful in helping identify a few opportunities for improvement!

@IEvangelist IEvangelist merged commit 60e5440 into main May 17, 2024
7 checks passed
@IEvangelist IEvangelist deleted the damianedwards/custom-resources-fixes branch May 17, 2024 19:56
@@ -109,6 +109,9 @@ Press <kbd>Ctrl</kbd>+<kbd>C</kbd> to shutdown the app (you can close the browse
dotnet add ./MailDev.Hosting/MailDev.Hosting.csproj package Aspire.Hosting --version 8.0.0-preview.7.24251.11
```

> [!IMPORTANT]
> The version you specify here should match the version of the .NET Aspire workload installed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, technically I don't think it needs to match the Aspire workload, but instead the version of Aspire.Hosting.AppHost package reference in the AppHost project.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(which ideally, both that and the workload would be the same version, but that is not always the case)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what is being added... it will always match itself 🤣. The .NET CLI command is adding a package reference to version 8.0.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right after the project is created, then yes, they will match of course. But think about the scenario where I have one workload version, create the project and push it to a repo, and you have a different workload version and pull the repo, and want to work on a client library (hosting package). This is what I meant that you'll want to match the version of the packagereference (which will match my workload as opposed to yours) instead of the version of your workload.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to change the versions back in a few days ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shhhhh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants