Skip to content

adding deployment steps to .NET Aspire + Redis to Azure #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 13, 2024
Merged

adding deployment steps to .NET Aspire + Redis to Azure #883

merged 3 commits into from
May 13, 2024

Conversation

CawaMS
Copy link
Contributor

@CawaMS CawaMS commented May 13, 2024 •
edited by github-actions bot
Loading

@CawaMS CawaMS requested a review from IEvangelist as a code owner May 13, 2024 06:07
@dotnet-bot dotnet-bot added the caching Content related to caching. label May 13, 2024
@CawaMS CawaMS mentioned this pull request May 13, 2024
Closed
IEvangelist
IEvangelist approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you. We'll :shipit: when you make the suggested changes.

IEvangelist
IEvangelist reviewed May 13, 2024
View reviewed changes
@CawaMS @IEvangelist
Apply suggestions from code review
01a932b 
Co-authored-by: David Pine <david.pine@microsoft.com>
@CawaMS
Copy link
Contributor Author

CawaMS commented May 13, 2024

@IEvangelist applied all suggestions in batch.

@IEvangelist IEvangelist merged commit 24f720b into dotnet:main May 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

Assignees
No one assigned
Labels
caching Content related to caching.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New article]: Run Aspire projects in Azure with Azure hosted Redis service Expand article to cover use of PublishAs extensions
3 participants
@CawaMS @IEvangelist @dotnet-bot