Skip to content

Address all issues in #720 #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2024
Merged

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented May 9, 2024

@dotnet-bot dotnet-bot added fundamentals Content related to fundamentals. getting-started Content related to getting started. labels May 9, 2024
@IEvangelist IEvangelist requested a review from adegeo May 9, 2024 23:23
@IEvangelist IEvangelist marked this pull request as ready for review May 10, 2024 12:45
@IEvangelist IEvangelist enabled auto-merge (squash) May 10, 2024 12:47
Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The only thing I noticed is that the screenshots are bigger than what the guidelines say we should use, which is 1600px wide. Any bigger and we should use lightbox versions.

@IEvangelist IEvangelist merged commit 01ee109 into dotnet:main May 13, 2024
7 checks passed
@IEvangelist IEvangelist deleted the fix-issues-in-720 branch May 23, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fundamentals Content related to fundamentals. getting-started Content related to getting started.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WebToolsE2E][Aspire][Document]Some more updates are needed to "Build your first .NET Aspire app" instructions using VS with aspire
3 participants