Skip to content

Fix search component name #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2024

Conversation

alexwolfmsft
Copy link
Contributor

@alexwolfmsft alexwolfmsft commented May 8, 2024

Summary

Rename search component as requested.

Fixes #826


Internal previews

📄 File 🔗 Preview link
docs/azureai/azureai-search-document-component.md .NET Aspire Azure AI Search Documents component

@alexwolfmsft alexwolfmsft requested a review from IEvangelist as a code owner May 8, 2024 13:11
@IEvangelist
Copy link
Member

Regardless of the package name, this is a product we're referring to. Whenever we talk about Azure AI Search, it needs to appear as such. If we're specifically talking about the package, then we can refer to it by the fully qualified package name, but when we talk about the underlying service, it should be "Azure AI Search".

@alexwolfmsft
Copy link
Contributor Author

Regardless of the package name, this is a product we're referring to. Whenever we talk about Azure AI Search, it needs to appear as such. If we're specifically talking about the package, then we can refer to it by the fully qualified package name, but when we talk about the underlying service, it should be "Azure AI Search".

So to clarify, when we are talking about the component by its friendly name, and not the technical package name, we would still want to call this ".NET Aspire Azure AI Search Documents component"?

@IEvangelist
Copy link
Member

Regardless of the package name, this is a product we're referring to. Whenever we talk about Azure AI Search, it needs to appear as such. If we're specifically talking about the package, then we can refer to it by the fully qualified package name, but when we talk about the underlying service, it should be "Azure AI Search".

So to clarify, when we are talking about the component by its friendly name, and not the technical package name, we would still want to call this ".NET Aspire Azure AI Search Documents component"?

Exactly—yes, that's my understanding of the style guidelines as it relates to official Azure service name references in conceptual content.

@IEvangelist
Copy link
Member

Hey @alexwolfmsft - do you need to make any updates per our discussion here?

@alexwolfmsft alexwolfmsft force-pushed the fix-search-component-name branch from a8b9d8e to 61c5949 Compare May 10, 2024 13:50
@alexwolfmsft
Copy link
Contributor Author

Hey @alexwolfmsft - do you need to make any updates per our discussion here?

Hey @IEvangelist I backed out most of the changes to keep the Azure AI service names, but left one fix for a link.

@IEvangelist IEvangelist merged commit 2b028e1 into dotnet:main May 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename component "Azure AI Search Documents" to "Azure Search Documents"
2 participants