Skip to content

Address feedback in #1670 #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 25, 2024
Merged

Address feedback in #1670 #1671

merged 8 commits into from
Sep 25, 2024

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Sep 24, 2024

Summary

  • Move integration listing under cloud-native content.
  • Remove note about provisioning.
  • Correct details about which type is extended.
  • Add more links back to app host content.
  • Added terminology bookmark.
  • Edit pass.

Fixes #1670.


Internal previews

📄 File 🔗 Preview link
docs/fundamentals/app-host-overview.md docs/fundamentals/app-host-overview
docs/fundamentals/health-checks.md docs/fundamentals/health-checks
docs/fundamentals/integrations-overview.md docs/fundamentals/integrations-overview
docs/fundamentals/service-defaults.md docs/fundamentals/service-defaults
docs/fundamentals/setup-tooling.md docs/fundamentals/setup-tooling

@dotnet-bot dotnet-bot added the fundamentals Content related to fundamentals. label Sep 24, 2024
@dotnet-policy-service dotnet-policy-service bot added the okr-quality Content-health KR: Concerns article defects/freshness or build warnings. label Sep 24, 2024
@DamianEdwards
Copy link
Member

In the cloud-native features section, we should consider removing the orchestration paragraph completely, as it currently reads as though the app host provides orchestration in the cloud rather than being for dev time only.

We should consider removing "cloud-native" from the section altogether actually, and focus more on what is actually added, i.e. service discovery and service defaults.

@IEvangelist
Copy link
Member Author

In the cloud-native features section, we should consider removing the orchestration paragraph completely, as it currently reads as though the app host provides orchestration in the cloud rather than being for dev time only.

We should consider removing "cloud-native" from the section altogether actually, and focus more on what is actually added, i.e. service discovery and service defaults.

To clarify, you're advocating for deleting all the Cloud-native content and its subsections?

Delete Cloud-native, Observability and telemetry, Health checks, and Resiliency sections?

IEvangelist and others added 2 commits September 24, 2024 11:20
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
@DamianEdwards
Copy link
Member

To clarify, you're advocating for deleting all the Cloud-native content and its subsections?

Delete Cloud-native, Observability and telemetry, Health checks, and Resiliency sections?

Re-frame, rather than delete. No "Cloud-native" heading or positioning.

Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IEvangelist IEvangelist merged commit a37f374 into dotnet:main Sep 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fundamentals Content related to fundamentals. okr-quality Content-health KR: Concerns article defects/freshness or build warnings.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow up feedback from new integration docs
6 participants