Skip to content

Update KeyVault usage documentation #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Update KeyVault usage documentation #1042

merged 1 commit into from
Jun 5, 2024

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Jun 5, 2024

The current documentation is out of date. Updating to match current APIs and behavior.

Related to #1041


Internal previews

📄 File 🔗 Preview link
docs/security/azure-security-key-vault-component.md .NET Aspire Azure Key Vault component

The current documentation is out of date. Updating to match current APIs and behavior.
@eerhardt eerhardt requested a review from bradygaster June 5, 2024 15:25
@eerhardt eerhardt requested a review from IEvangelist as a code owner June 5, 2024 15:25
@dotnet-bot dotnet-bot added the security Content related to security. label Jun 5, 2024
@IEvangelist
Copy link
Member

Thanks @eerhardt - is this related to #1041?

Copy link
Member

@bradygaster bradygaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's make sure this gets reviewed by @IEvangelist, too. Thanks for jumping on this, @eerhardt!

@eerhardt
Copy link
Member Author

eerhardt commented Jun 5, 2024

is this related to #1041?

Yes, it addresses the first comment in that issue:

1.) extension method AddAzureKeyVaultSecrets does not exists after one adds Aspire.Azure.Security.KeyVault to the consuming project

@IEvangelist IEvangelist merged commit 492f090 into main Jun 5, 2024
9 checks passed
@IEvangelist IEvangelist deleted the eerhardt-patch-1 branch June 5, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Content related to security.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants