Merging internal commits for release/8.0 #62615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harden Cookie parsing ---- #### AI description (iteration 1) #### PR Classification Bug fix focused on enforcing stricter cookie parsing rules in accordance with RFC 6265. #### PR Summary This pull request refines cookie parsing by updating test datasets and parser logic to reject improperly formatted cookie headers. The changes include: - **`src/Http/Headers/test/CookieHeaderValueTest.cs`**: Renamed and modified test datasets to use strict parsing (e.g., renaming to ListOfStrictCookieHeaderDataSet) and update expected results for invalid cookie combinations. - **`src/Http/Http/test/RequestCookiesCollectionTests.cs`**: Revised inline test cases to expect null outcomes for malformed cookies and added new cases for additional invalid formats. - **`src/Http/Shared/CookieHeaderParserShared.cs`**: Enhanced parsing logic to skip invalid cookie segments by enforcing semicolon delimiters and incorporating detailed RFC comment documentation. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
…otnet-runtime build 20250611.17 Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 8.0.17-servicing.25266.2 -> To Version 8.0.18-servicing.25311.17
…ng/internal/dotnet-runtime This pull request updates the following dependencies [marker]: <> (Begin:83131e87-e80d-4d5b-f426-08dbd53b3319) ## From https://dev.azure.com/dnceng/internal/_git/dotnet-runtime - **Subscription**: [83131e87-e80d-4d5b-f426-08dbd53b3319](https://maestro.dot.net/subscriptions?search=83131e87-e80d-4d5b-f426-08dbd53b3319) - **Build**: [20250611.17](https://dev.azure.com/dnceng/internal/_build/results?buildId=2728343) - **Date Produced**: June 12, 2025 10:51:57 AM UTC - **Commit**: [ef853a71052646a42abf17e888ec6d9a69614ad9](https://dev.azure.com/dnceng/internal/_git/dotnet-runtime?_a=history&version=GCef853a71052646a42abf17e888ec6d9a69614ad9) - **Branch**: refs/heads/internal/release/8.0 [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.Extensions.HostFactoryResolver.Sources**: [from 8.0.17-servicing.25266.2 to 8.0.18-servicing.25311.17][1] - **Microsoft.Internal.Runtime.AspNetCore.Transport**: [from 8.0.17-servicing.25266.2 to 8.0.18-servicing.25311.17][1] - **Microsoft.NET.Runtime.MonoAOTCompiler.Task**: [from 8.0.17 to 8.0.18][1] - **Microsoft.NET.Runtime.WebAssembly.Sdk**: [from 8.0.17 to 8.0.18][1] - **Microsoft.NETCore.App.Ref**: [from 8.0.17 to 8.0.18][1] - **Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm**: [from 8.0.17 to 8.0.18][1] - **Microsoft.NETCore.App.Runtime.win-x64**: [from 8.0.17 to 8.0.18][1] - **Microsoft.NETCore.BrowserDebugHost.Transport**: [from 8.0.17-servicing.25266.2 to 8.0.18-servicing.25311.17][1] - **Microsoft.NETCore.Platforms**: [from 8.0.17-servicing.25266.2 to 8.0.18-servicing.25311.17][1] - **System.Text.Json**: [from 8.0.5 to 8.0.6][2] - **Microsoft.SourceBuild.Intermediate.runtime.linux-x64**: [from 8.0.17-servicing.25266.2 to 8.0.18-servicing.25311.17][1] [1]: https://dev.azure.com/dnceng/internal/_git/dotnet-runtime/branches?baseVersion=GC77545d6fd5ca79bc08198fd6d8037c14843f14ad&targetVersion=GCef853a71052646a42abf17e888ec6d9a69614ad9&_a=files [2]: https://dev.azure.com/dnceng/internal/_git/dotnet-runtime/branches?baseVersion=GC81cabf2857a01351e5ab578947c7403a5b128ad1&targetVersion=GCef853a71052646a42abf17e888ec6d9a69614ad9&_a=files [DependencyUpdate]: <> (End) [marker]: <> (End:83131e87-e80d-4d5b-f426-08dbd53b3319)
…otnet-efcore build 20250611.8 dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.Tools From Version 8.0.17 -> To Version 8.0.18
…ng/internal/dotnet-efcore This pull request updates the following dependencies [marker]: <> (Begin:e179a2a7-bc5d-4498-2467-08dbd53ba9ce) ## From https://dev.azure.com/dnceng/internal/_git/dotnet-efcore - **Subscription**: [e179a2a7-bc5d-4498-2467-08dbd53ba9ce](https://maestro.dot.net/subscriptions?search=e179a2a7-bc5d-4498-2467-08dbd53ba9ce) - **Build**: [20250611.8](https://dev.azure.com/dnceng/internal/_build/results?buildId=2728042) - **Date Produced**: June 11, 2025 4:39:07 PM UTC - **Commit**: [76582c579cc4de7faa4b59e6620f81ba142d6969](https://dev.azure.com/dnceng/internal/_git/dotnet-efcore?_a=history&version=GC76582c579cc4de7faa4b59e6620f81ba142d6969) - **Branch**: refs/heads/internal/release/8.0 [DependencyUpdate]: <> (Begin) - **Updates**: - **dotnet-ef**: [from 8.0.17 to 8.0.18][1] - **Microsoft.EntityFrameworkCore**: [from 8.0.17 to 8.0.18][1] - **Microsoft.EntityFrameworkCore.Design**: [from 8.0.17 to 8.0.18][1] - **Microsoft.EntityFrameworkCore.InMemory**: [from 8.0.17 to 8.0.18][1] - **Microsoft.EntityFrameworkCore.Relational**: [from 8.0.17 to 8.0.18][1] - **Microsoft.EntityFrameworkCore.Sqlite**: [from 8.0.17 to 8.0.18][1] - **Microsoft.EntityFrameworkCore.SqlServer**: [from 8.0.17 to 8.0.18][1] - **Microsoft.EntityFrameworkCore.Tools**: [from 8.0.17 to 8.0.18][1] [1]: https://dev.azure.com/dnceng/internal/_git/dotnet-efcore/branches?baseVersion=GCf7b16ef09831139dd1b087f281910e2446129bef&targetVersion=GC76582c579cc4de7faa4b59e6620f81ba142d6969&_a=files [DependencyUpdate]: <> (End) [marker]: <> (End:e179a2a7-bc5d-4498-2467-08dbd53ba9ce)
…otnet-efcore build 20250612.3 dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.Tools From Version 8.0.18 -> To Version 8.0.18
…ng/internal/dotnet-efcore This pull request updates the following dependencies [marker]: <> (Begin:e179a2a7-bc5d-4498-2467-08dbd53ba9ce) ## From https://dev.azure.com/dnceng/internal/_git/dotnet-efcore - **Subscription**: [e179a2a7-bc5d-4498-2467-08dbd53ba9ce](https://maestro.dot.net/subscriptions?search=e179a2a7-bc5d-4498-2467-08dbd53ba9ce) - **Build**: [20250612.3](https://dev.azure.com/dnceng/internal/_build/results?buildId=2728751) - **Date Produced**: June 16, 2025 9:17:08 PM UTC - **Commit**: [271c94d1d96b2bc0b22f9f60d07f1d93abd0894f](https://dev.azure.com/dnceng/internal/_git/dotnet-efcore?_a=history&version=GC271c94d1d96b2bc0b22f9f60d07f1d93abd0894f) - **Branch**: refs/heads/internal/release/8.0 [DependencyUpdate]: <> (Begin) - **Updates**: - **dotnet-ef**: [from 8.0.18 to 8.0.18][1] - **Microsoft.EntityFrameworkCore**: [from 8.0.18 to 8.0.18][1] - **Microsoft.EntityFrameworkCore.Design**: [from 8.0.18 to 8.0.18][1] - **Microsoft.EntityFrameworkCore.InMemory**: [from 8.0.18 to 8.0.18][1] - **Microsoft.EntityFrameworkCore.Relational**: [from 8.0.18 to 8.0.18][1] - **Microsoft.EntityFrameworkCore.Sqlite**: [from 8.0.18 to 8.0.18][1] - **Microsoft.EntityFrameworkCore.SqlServer**: [from 8.0.18 to 8.0.18][1] - **Microsoft.EntityFrameworkCore.Tools**: [from 8.0.18 to 8.0.18][1] [1]: https://dev.azure.com/dnceng/internal/_git/dotnet-efcore/branches?baseVersion=GC76582c579cc4de7faa4b59e6620f81ba142d6969&targetVersion=GC271c94d1d96b2bc0b22f9f60d07f1d93abd0894f&_a=files [DependencyUpdate]: <> (End) [marker]: <> (End:e179a2a7-bc5d-4498-2467-08dbd53ba9ce)
#### AI description (iteration 1) #### PR Classification Configuration update that ensures analyzers use the live version of System.Text.Json. #### PR Summary This PR modifies the `/eng/Versions.props` file to dynamically reference the live System.Text.Json version instead of a fixed version. - `/eng/Versions.props`: Replaced the hard-coded `<AnalyzersSystemTextJsonVersion>8.0.5</AnalyzersSystemTextJsonVersion>` with `$(SystemTextJsonVersion)`. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
…-merge-8.0-2025-07-08-1424
vseanreesermsft
requested review from
BrennanConroy,
halter73,
captainsafia,
dotnet-maestro-bot,
wtgodbe and
a team
as code owners
BrennanConroy
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.