QuickGrid: Adds option to disable rendering of filler rows #62607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Thanks for your PR, @@los93sol. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QuickGrid: Adds option to disable rendering of filler rows
Description
This pull request add an option to PaginationState to disable rendering of filler rows. It keeps the default functionality of rendering the filler rows. I understand that one way to deal with this is to style it with CSS, but in some cases that's impractical, overly complex, and desirable. This provides users the ability to choose how they want it to behave without being forced to use CSS which prevents them from changing from one method to another on a per instance basis. The existing code noted that it should be considered to make it optional as well.
NOTE: I submitted this previously but I needed to move it to a feature branch and continue working it down to ensure all the checks are passing.
@Nick-Stanton I'm tagging you since it looks like you were the original author that added the comment that it should be considered to make this functionality optional.
Fixes #57199 #59096