Update all built-in AuthenticationSchemeOptions to initialize Events #62595
+17
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not exactly sure why
Events
isn't always initialized to a non-null value especially given that the type is mark. It is in a bunch of otherAuthenticationSchemeOptions
likeCookieAuthenticationOptions
,OpenIdConnectOptions
,BearerTokenOptions
, etc. Changing it now for existing options type could theoretically break people who already used something likeoptions.Events ??= new ....
although I imagine most code would either omit the??
part or only initialize to the default Events type.Maybe the idea during the initial design of these types was that more people would derive from the Events type and set the Events property to their custom type during the initial design, but I don't think I've ever seen that outside of our tests.
Fixes #43313