Support *.localhost TLD for local dev #62593
Conversation
DamianEdwards
requested review from
halter73,
BrennanConroy,
JamesNK,
captainsafia and
a team
as code owners
github-actions
bot
added
the
area-mvc
| } | ||
| ], | ||
| "shortName": "blazor", | ||
| "sourceName": "BlazorWeb-CSharp", | ||
| "sourceName": "BlazorWebCSharp.1", |
There was a problem hiding this comment.
This change was required in order to support all the default value forms for the sourceName in accordance with the docs for sourceName. Specifically, we want to use the lower case class name form for the value of "applicationUrl" in the launchSettings.json file.
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
@lewing seems it's failing in main the same way |
yeah I was hoping the windows images had been successfully rolled back by now, clearly they have not |
| @@ -19,8 +19,8 @@ namespace Microsoft.AspNetCore.Certificates.Generation; | |||
|
|
|||
| internal abstract class CertificateManager | |||
| { | |||
| internal const int CurrentAspNetCoreCertificateVersion = 3; | |||
| internal const int CurrentMinimumAspNetCoreCertificateVersion = 3; | |||
| internal const int CurrentAspNetCoreCertificateVersion = 4; | |||
There was a problem hiding this comment.
nit: do we need to increment this if we already did it for 10.0?
There was a problem hiding this comment.
We're shipping revision 3 in preview.6 so we need to increment again for preview.7 otherwise folks using the previews won't get the new certificate.
…ub.com/dotnet/aspnetcore into damianedwards/dev-cert-additional-sans
|
@BrennanConroy addressed your feedback, thanks! |
Support *.localhost TLD for local dev
Description
This PR adds support to ASP.NET Core for local dev with a
*.localhostaddress, i.e. an address using the.localhostTLD.The
.localhostTLD is always resolved to the localhost loopback address in modern browsers without any DNS configuration required (as per RFC 6761). It's effectively an alias forlocalhost, allowing for infinite variations on the host name while maintaining the benefits of the localhost address. An ASP.NET Core application started with anASPNETCORE_URLSconfig value (or"applicationUrl"in launchSettings.json) will be resolvable on any address that binds to the loopback address, so a value ofhttp://myapp.localhost:12345will also be resolvable viahttp://localhost:12345. Note that non-browser scenarios should continue to use the plain localhost address as they rely on regular DNS configuration to resolve a.localhostTLD address to the loopback address.The empty and blazor web templates have been updated with a new option,
--localhost-tld, that can be specified to opt the new project into using the.localhostTLD for the application URL. The other templates focusing on non-browser scenarios or using parts of ASP.NET Core not considered our primary, modern, recommended approach, have not been updated but users are free to manually change their launch profiles to use the.localhostTLD.Kestrel itself was updated to treat
.localhostaddresses the same as thelocalhostaddress. In the case a.localhostaddress is being used, Kestrel will print out that it's listening on both the.localhostaddress, and regularlocalhostwithout the sub-domain prefix too so it's obvious that both are resolvable, e.g.:The developer certificate logic had the certificate version incremented, and was updated to include new SANs for the following addresses:
*.localhost*.internalFixes #62592