Add test for the order of activity and metrics with HTTP requests #56592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @noahfalk @tarekgh @antonfirsov A test that verifies an activity is active when a metric is recorded. This kind of test should be applied to HttpClient (it currently doesn't do the right thing) and anywhere else in the future that combines a duration histogram and activity. |
| var hostingEventSource = new HostingEventSource(Guid.NewGuid().ToString()); | ||
| using var activityListener = new ActivityListener | ||
| { | ||
| ShouldListenTo = activitySource => activitySource.Name == "Microsoft.AspNetCore", |
There was a problem hiding this comment.
You should create an activity source, inject it, and use reference equal so the test isn't affected by other tests.
See prior examples:
There was a problem hiding this comment.
I don't think it matters for this test because it doesn't actually listen for activities and then use them. We're only listening so an activity is created.
But, for consistency and to reduce confusion, I'll update the test.
JamesNK
force-pushed
the
jamesnk/metrics-activity-order-test
branch
from
bb25c67 to
79ec511
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exemplars require metrics and activities are completed in the correct order. ASP.NET Core fortunately already does the right thing.
Add comments and a unit test to assert the correct behavior.