Avoid StringSegment conversions #56533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid 1 or 2 implicit conversions to `StringSegment` from `string` per invocation of `StringWithQualityHeaderValueComparer.Compare()` by re-using a static field.
martincostello
requested review from
BrennanConroy,
halter73 and
captainsafia
as code owners
ghost
added
the
area-networking
dotnet-policy-service
bot
added
the
community-contribution
dotnet-policy-service
bot
added
the
pending-ci-rerun
martincostello
removed
the
pending-ci-rerun
amcasey
approved these changes
Jul 15, 2024
| @@ -14,6 +14,8 @@ namespace Microsoft.Net.Http.Headers; | |||
| /// </summary> | |||
| public class StringWithQualityHeaderValueComparer : IComparer<StringWithQualityHeaderValue> | |||
| { | |||
| private static readonly StringSegment Any = new("*"); | |||
There was a problem hiding this comment.
I might call it "AnyQuality", but I don't feel strongly about it.
|
Good to merge? |
|
Sorry, I was giving the other reviewers a little time, but things have been crazy here and no one's had time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid StringSegment conversions
Avoid implicit conversions from
stringtoStringSegment.Description
Avoid 1 or 2 implicit conversions to
StringSegmentfromstringper invocation ofStringWithQualityHeaderValueComparer.Compare()by re-using a static field.