Amortise HTTP Result Content-Type arrays #56525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Amortise arrays used for `TypedResults`' metadata. - Use `ProducesResponseTypeMetadata.CreateUnvalidated` to bypass `Content-Type` validation for static values. - Add and use constant for `application/octet-stream`.
martincostello
requested review from
BrennanConroy,
halter73 and
captainsafia
as code owners
ghost
added
the
area-networking
dotnet-policy-service
bot
added
the
community-contribution
dotnet-policy-service
bot
added
the
pending-ci-rerun
martincostello
removed
the
pending-ci-rerun
Wonder if we should add these to our .editorconfig |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amortise Content-Type arrays
Amortise the
Content-Typearrays used for HTTP result endpoint metadata.Description
TypedResults' metadata.ProducesResponseTypeMetadata.CreateUnvalidated()to bypassContent-Typevalidation for these static values. If theInternalsVisibleTois undesirable, this could be reverted but this would need the re-used content-types to astring[], which then means they could in theory be edited at runtime via a cast as the compiler generated<>z__ReadOnlyArray`1type would no longer be used for the collection expression.application/octet-stream.The changes resolve a number of
CA1861,IDE0028andIDE0300analyser suggestions.The theory is that the re-use of the arrays and ability to bypass the
Content-Typevalidation will reduce the an application's memory usage and speed up the population of endpoint metadata.