Skip to content

Add overloads for problem and validation problem results that accept IEnumerable<KeyValuePair<,>> #56368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 8, 2024
Merged

Add overloads for problem and validation problem results that accept IEnumerable<KeyValuePair<,>> #56368

merged 14 commits into from
Jul 8, 2024

Conversation

joegoldman2
Copy link
Contributor

@joegoldman2 joegoldman2 commented Jun 21, 2024 •
edited
Loading

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

This PRs add overloads for problem and validation problem results that accept IEnumerable<KeyValuePair<,>>.

For the moment I'm not sure to understand why I get the warning RS0026 Symbol 'ValidationProblem' violates the backcompat requirement: 'Do not add multiple overloads with optional parameters', so I'm open to suggestions.

Fixes #41899.
Fixes #56370.

@ghost ghost added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Jun 21, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 21, 2024
halter73
halter73 reviewed Jun 21, 2024
View reviewed changes
amcasey
amcasey reviewed Jun 27, 2024
View reviewed changes
amcasey
amcasey reviewed Jun 27, 2024
View reviewed changes
@joegoldman2 joegoldman2 requested a review from amcasey June 28, 2024 22:17
@build-analysis build-analysis bot mentioned this pull request Jun 29, 2024
Open
3 tasks
@build-analysis build-analysis bot mentioned this pull request Jun 29, 2024
Open
3 tasks
halter73
halter73 reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is looking good.

amcasey
amcasey approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @halter73 said.

@halter73 halter73 merged commit 7f9b45e into dotnet:main Jul 8, 2024
26 checks passed
@halter73
Copy link
Member

halter73 commented Jul 8, 2024

Thanks!

@joegoldman2 joegoldman2 deleted the fix/41899 branch July 8, 2024 18:59
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview7 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar left review comments

@333fred 333fred 333fred left review comments

@halter73 halter73 halter73 approved these changes

@amcasey amcasey amcasey approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

Assignees

@adityamandaleeka adityamandaleeka

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
9.0-preview7
6 participants
@joegoldman2 @halter73 @jaredpar @333fred @amcasey @adityamandaleeka