-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Enable input number component to support type='range' attribute #55583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MackinnonBuck
merged 19 commits into
dotnet:main
from
MattyLeslie:Enable-InputNumber-Component-to-Support-type='range'-Attribute
Jul 26, 2024
Merged
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
ca712c1
Commit modifies the InputNumber component to allow the 'type' attribu…
MattyLeslie f9ceb16
Adding a test to the inputNumberTests to ensure the user defined type…
MattyLeslie 525b346
Merge branch 'dotnet:main' into Enable-InputNumber-Component-to-Suppo…
MattyLeslie bfa7733
Using the TestRederer to extract attributes and assert the user-defin…
MattyLeslie ce3d8c0
Merge branch 'Enable-InputNumber-Component-to-Support-type='range'-At…
MattyLeslie 8df498d
Retrieving frames with new methodology
MattyLeslie c7a76af
Isolating the correct element to extract attributes from
MattyLeslie ac09491
Only asserting the type attribute = range
MattyLeslie dd6b779
Isolating input element, atrributes and type attribute correctly
MattyLeslie 7b2ee01
Improving methodology of handling render tree frames and isolating th…
MattyLeslie ebf82de
Ammendments to tests
MattyLeslie af90057
Merge branch 'dotnet:main' into Enable-InputNumber-Component-to-Suppo…
MattyLeslie d1f916e
Merge branch 'dotnet:main' into Enable-InputNumber-Component-to-Suppo…
MattyLeslie b1ab8e0
Update src/Components/Web/test/Forms/InputNumberTest.cs
MattyLeslie bf70742
Update src/Components/Web/test/Forms/InputNumberTest.cs
MattyLeslie abfb3e6
Update src/Components/Web/test/Forms/InputNumberTest.cs
MattyLeslie 11aa774
re-adding missing tests
MattyLeslie 6e7ca94
Using helper methods in tests.
MattyLeslie c717209
Update src/Components/Web/test/Forms/InputNumberTest.cs
MackinnonBuck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.