[Blazor] Fix multiple CSP policies #55200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
JamesNK
approved these changes
Apr 18, 2024
src/Components/Server/src/Builder/ServerRazorComponentsEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
| } | ||
| else | ||
| { | ||
| Assert.DoesNotContain("Content-Security-Policy", response.Headers.Select(h => h.Key)); |
There was a problem hiding this comment.
Is this assertion really correct? If you're requesting the ?add-csp response, that should add at least one CSP in all cases, wouldn't it?
Or is it possible this test code never actually runs? It's hard to reason about with the subclasses and ExpectedPolicy etc.
There was a problem hiding this comment.
Yeah, it's hard to write these tests. I copy pasted it from another test but validated that it works (that section doesn't run).
I'll clean that up.
JamesNK
reviewed
Apr 18, 2024
src/Components/test/E2ETest/ServerExecutionTests/WebSocketCompressionTests.cs
Show resolved
Hide resolved
…tConventionBuilderExtensions.cs Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
javiercn
commented
Apr 18, 2024
src/Components/test/E2ETest/ServerExecutionTests/WebSocketCompressionTests.cs
Outdated
Show resolved
Hide resolved
javiercn
commented
Apr 18, 2024
src/Components/test/E2ETest/ServerExecutionTests/WebSocketCompressionTests.cs
Outdated
Show resolved
Hide resolved
src/Components/test/E2ETest/ServerExecutionTests/WebSocketCompressionTests.cs
Show resolved
Hide resolved
SteveSandersonMS
approved these changes
Apr 18, 2024
…ressionTests.cs Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the CSP policy handling by Blazor to append to an existing policy if present.