Skip to content

Ensuring deleted cookies are recognized by the browser by ensuring the MaxAge within CookieOptions is set to null. #55169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 19, 2024
Merged

Ensuring deleted cookies are recognized by the browser by ensuring the MaxAge within CookieOptions is set to null. #55169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b505487
Explicitly appending the MaxAge as null at the end of the delete meth…
MattyLeslie Apr 16, 2024
9adf53e
Ensuring the IsEssential property of CookieOptions is carried
MattyLeslie Apr 16, 2024
dfcf06d
Merge branch 'dotnet:main' into #52159
MattyLeslie Apr 16, 2024
b5b762d
syntax error.
MattyLeslie Apr 16, 2024
da8e231
Merge branch 'dotnet:main' into #52159
MattyLeslie Apr 17, 2024
28e6b39
Simplifying the change to just override MaxAge and Expires when appen…
MattyLeslie Apr 17, 2024
51a2fc0
Merge branch 'dotnet:main' into #52159
MattyLeslie Apr 17, 2024
c58ed9b
Adding insightful comment to ResponseCookies.cs
MattyLeslie Apr 19, 2024
b5e9735
Ammending the methods DeleteCookie() and DeleteChunks() to ensure Max…
MattyLeslie Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Http/Http/src/Internal/ResponseCookies.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ public void Delete(string key, CookieOptions options)
Append(key, string.Empty, new CookieOptions(options)
{
Expires = DateTimeOffset.UnixEpoch,
MaxAge = null, // Some browsers require this (https://github.com/dotnet/aspnetcore/issues/52159)
});
}

Expand Down
2 changes: 2 additions & 0 deletions src/Shared/ChunkingCookieManager/ChunkingCookieManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ public void DeleteCookie(HttpContext context, string key, CookieOptions options)
responseCookies.Append(keyValuePairs, new CookieOptions(options)
{
Expires = DateTimeOffset.UnixEpoch,
MaxAge = null, // Some browsers require this (https://github.com/dotnet/aspnetcore/issues/52159)
});
}

Expand Down Expand Up @@ -331,6 +332,7 @@ private static void DeleteChunks(HttpContext context, IRequestCookieCollection r
context.Response.Cookies.Append(keyValuePairs.ToArray(), new CookieOptions(options)
{
Expires = DateTimeOffset.UnixEpoch,
MaxAge = null, // Some browsers require this (https://github.com/dotnet/aspnetcore/issues/52159)
});
}
}
Expand Down
Loading