Skip to content

Fix route pattern analyzer false positive with catch-all parameter #55129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix route pattern analyzer false positive with catch-all parameter #55129

wants to merge 2 commits into from

Conversation

joegoldman2
Copy link
Contributor

Fixes #52628.

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 15, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 15, 2024
@martincostello martincostello added the analyzer Indicates an issue which is related to analyzer experience label Apr 15, 2024
@mkArtakMSFT mkArtakMSFT added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates and removed area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework labels Apr 15, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Apr 22, 2024
@JamesNK
Copy link
Member

JamesNK commented Apr 26, 2024

This doesn't look like a bug to me. This is only an info level analyzer suggestion. Its advice could follow or choose to ignore.

@joegoldman2
Copy link
Contributor Author

@JamesNK should we close this PR and the associated issue in this case?

@JamesNK
Copy link
Member

JamesNK commented Apr 26, 2024

Yes. I'll do that now.

@JamesNK JamesNK closed this Apr 26, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview5 milestone Apr 26, 2024
@joegoldman2 joegoldman2 deleted the fix/52628 branch May 7, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JamesNK JamesNK

Labels
analyzer Indicates an issue which is related to analyzer experience area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Milestone
9.0-preview5
Development

Successfully merging this pull request may close these issues.

ASP0018 complains about catch-all parameter without proposing any solutions
4 participants
@joegoldman2 @JamesNK @martincostello @mkArtakMSFT