Update diagnostic URLs

[adegeo]

Description

Technically depends on dotnet/docs-aspire#3379 but it's not required to merge. Docs will ship soon. Done

Intellisense didn't show HelpLink on the MSBuild actions, but the MSBuild docs said it's supported.

Fixes #8936

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
• Are you including unit tests for the changes and scenario tests if relevant?
  • No
• Did you add public API?
  • No
• Does the change make any security assumptions or guarantees?
  • No
• Does the change require an update in our Aspire docs?
  • Yes, already in progress

[danmoseley]

Assuming we get the aka links up before we ship, lgtm.

[danmoseley]

if it matters, some of these are not in https://github.com/dotnet/aspire/blob/main/docs/list-of-diagnostics.md

(not sure why we have htat file exactly though)

[adegeo]

It could be a reference file devs should use to look up existing IDs? But honestly you should have a review process about creating those with some approval mechanism and really you should switch to using a constant. It's very easy to accidentally name one wrong when you're trying to apply it. 😁

[RussKie]

Any reason we're changing the convention (which is https://aka.ms/dotnet/<repo>/diagnostics#{0})?

[danmoseley]

Yes, we're doing work (such as the CLI) to make Aspire accessible to non-.NET developers, so it makes sense.

[adegeo]

I created the aka links using diagnostics not diagnostic... Let me fix. We can alter the code or adjust each link. Find replace in code is quicker than using the web UI to adjust each link.