-
Notifications
You must be signed in to change notification settings - Fork 311
Merge | SqlCommand (Part 1) #3473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…cing method name parameters)
…s to align with netfx implementation
…EncryptionMetadata
…roperty Transfer all _cachedAsyncState usages to CachedAsyncState This could be dangerous since property behavior is slightly different than the direct member variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3473 +/- ##
==========================================
- Coverage 68.86% 67.78% -1.08%
==========================================
Files 280 277 -3
Lines 62417 62389 -28
==========================================
- Hits 42982 42293 -689
- Misses 19435 20096 +661
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs
Show resolved
Hide resolved
…functions to align with netfx implementation" This reverts commit 6fccc8f. Align netfx implementation with netcore implementation
Description
This PR is a collection of changes to both SqlCommand implementations to bring them closer together. Although the bulk of SqlCommand is the same, it is a huge class and very hard to reconcile all the differences cleanly. I have no idea what's the best way to handle this merge, so I figure I'll do it in chunks that will be digestible.
In this installment, I've tried to tackle the small differences that are just really annoying to go through. These changes includes:
[CallerMemberName]
and calls to such methodsisAsync
isRetry
Issues
Testing
Code changes are pretty low stakes syncing between the two implementations. CI should be suitable to vaidate.