Merge | TdsParser.GetSniErrorDetails #3434
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
benrr101
previously approved these changes
Jun 23, 2025
benrr101
added
Code Health 💊
paulmedynski
requested changes
Jun 25, 2025
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs
Outdated
Show resolved
Hide resolved
paulmedynski
previously approved these changes
Jun 25, 2025
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
samsharma2700
previously approved these changes
Jul 3, 2025
| { | ||
| SniError sniError = SniProxy.Instance.GetLastError(); | ||
|
|
||
| return new SniErrorDetails(sniError.errorMessage, sniError.nativeError, sniError.sniError, (int)sniError.provider, sniError.lineNumber, sniError.function, sniError.exception); |
There was a problem hiding this comment.
nit: Please consider chopping these into multiple lines.
There was a problem hiding this comment.
Thanks. Formatted in both places, with the exception parameter on an extra line for netcore.
| { | ||
| SniNativeWrapper.SniGetLastError(out SniError sniError); | ||
|
|
||
| return new SniErrorDetails(sniError.errorMessage, sniError.nativeError, sniError.sniError, (int)sniError.provider, sniError.lineNumber, sniError.function); |
edwardneal
dismissed stale reviews from samsharma2700 and paulmedynski
via
d643b06
paulmedynski
approved these changes
Jul 4, 2025
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3434 +/- ##
==========================================
- Coverage 63.51% 59.63% -3.88%
==========================================
Files 293 274 -19
Lines 63810 62012 -1798
==========================================
- Hits 40526 36983 -3543
- Misses 23284 25029 +1745
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a slightly smaller merge, but it's the first of its type.
TdsParser.Windows.cs and TdsParser.Unix.cs have a number of methods which vary in behaviour based upon
TdsParserStateObjectFactory.UseManagedSNI. This PR handles those methods by moving the method to theTdsParserStateObjectbase class, implementing them in the Native and Managed child classes, then updating the references to use the state object.Once this process is complete, we'll be able to remove the OS-specific TdsParser files.
Issues
Contributes to #1261.
Testing
Unit tests pass locally, but I'd like a CI run please.