Skip to content

Improve async string perf and fix reading chars with initial offset. #3377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 4, 2025
+121 −21
Merged

Improve async string perf and fix reading chars with initial offset. #3377

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
412b873
refine handling of moving between replay and continue states
Wraith2 May 26, 2025
32d8b9e
for plp reads increase the buffer size in relatively small chunks to …
Wraith2 May 11, 2025
e1964c9
change TryReadPlpUnicodeChars to check plp length field not max len p…
Wraith2 May 11, 2025
9638d61
sync netfx and netcore
Wraith2 May 11, 2025
8a8ffaa
add test covering #3331 and fix
Wraith2 May 11, 2025
68c4322
re-remove CurrentPacketIndex, fix test name error
Wraith2 May 26, 2025
e8df89e
review feedback
Wraith2 May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13096,9 +13096,9 @@ bool writeDataSizeToSnapshot
// If total length is known up front, the length isn't specified as unknown
// and the caller doesn't pass int.max/2 indicating that it doesn't know the length
// allocate the whole buffer in one shot instead of realloc'ing and copying over each time
if (buff == null && stateObj._longlen != TdsEnums.SQL_PLP_UNKNOWNLEN && len < (int.MaxValue >> 1))
if (buff == null && stateObj._longlen != TdsEnums.SQL_PLP_UNKNOWNLEN && stateObj._longlen < (int.MaxValue >> 1))
{
if (supportRentedBuff && len < 1073741824) // 1 Gib
if (supportRentedBuff && stateObj._longlen < 1073741824) // 1 Gib
{
buff = ArrayPool<char>.Shared.Rent((int)Math.Min((int)stateObj._longlen, len));
rentedBuff = true;
Expand Down