Skip to content

New pool scaffolding #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 22, 2025
Merged

New pool scaffolding #3352

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
df8dcb7
Add app context switch
mdaigle May 15, 2025
971e0c0
Add ChannelDbConnectionPool shim and instantiate in pool group based …
mdaigle May 15, 2025
e112110
Clean up connection pool interface. Rename TaskCompletionSource param…
mdaigle May 15, 2025
60e94ec
Cleanup
mdaigle May 15, 2025
f8aee85
Fix app context switch evaluation.
mdaigle May 15, 2025
b8fde3e
Add license statement and class summary
mdaigle May 15, 2025
256f558
Change DbConnection pool from abstract to interface.
mdaigle May 16, 2025
393f175
Add doc comments. Refactor params for consistency.
mdaigle May 16, 2025
540e93f
Add unit test for context switch default value.
mdaigle May 16, 2025
4bebb1b
Merge main
mdaigle May 16, 2025
a424037
Add class summary for WaitHandleDbConnectionPool
mdaigle May 16, 2025
d0ca337
Rename ObjectId property to Id.
mdaigle May 16, 2025
6067bd1
Fix reflection of pool count.
mdaigle May 19, 2025
aac03ad
Fix binding flags.
mdaigle May 19, 2025
b799f10
Fix property ordering. Inherit doc comments.
mdaigle May 19, 2025
6ea1491
Defer new pool class to next PR. Add test to boost code coverage.
mdaigle May 19, 2025
32b31e5
Try to fix app context switch setting.
mdaigle May 20, 2025
d6b8eb5
Remove flaky test. Planned to replace this in the near future anyways.
mdaigle May 21, 2025
831dc5b
Clean up test file.
mdaigle May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionPoolTest/ConnectionPoolTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using System;
using System.Collections;
using System.Collections.Generic;
using System.Reflection;
using System.Threading;
using System.Threading.Tasks;
using Xunit;
Expand Down Expand Up @@ -73,6 +74,13 @@ public static void BasicConnectionPoolingTest(string connectionString)
}
}

private enum Tristate : byte
{
NotInitialized = 0,
False = 1,
True = 2
}

/// <summary>
/// Tests that when UseConnectionPoolV2 context switch is enabled, opening a connection throws NotImplementedException
/// </summary>
Expand All @@ -82,8 +90,9 @@ public static void UseConnectionPoolV2ThrowsNotImplemented(string connectionStri
{
try
{
// Enable the UseConnectionPoolV2 context switch
AppContext.SetSwitch("Switch.Microsoft.Data.SqlClient.UseConnectionPoolV2", true);
Type switchesType = typeof(SqlCommand).Assembly.GetType("Microsoft.Data.SqlClient.LocalAppContextSwitches");
FieldInfo switchField = switchesType.GetField("s_useConnectionPoolV2", System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Static);
switchField.SetValue(null, Tristate.True);

using (SqlConnection connection = new SqlConnection(connectionString))
{
Expand All @@ -94,7 +103,9 @@ public static void UseConnectionPoolV2ThrowsNotImplemented(string connectionStri
finally
{
// Reset the context switch
AppContext.SetSwitch("Switch.Microsoft.Data.SqlClient.UseConnectionPoolV2", false);
Type switchesType = typeof(SqlCommand).Assembly.GetType("Microsoft.Data.SqlClient.LocalAppContextSwitches");
FieldInfo switchField = switchesType.GetField("s_useConnectionPoolV2", System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Static);
switchField.SetValue(null, Tristate.False);
}
}

Expand Down
Loading