-
Notifications
You must be signed in to change notification settings - Fork 311
Tests | Remove hardcoded credentials from ManualTests #3204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
benrr101
merged 19 commits into
main
from
dev/russellben/en-manual-tests-certificate-gen
Jun 5, 2025
Merged
Changes from 11 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
bbe8410
Initial removal of CertificateUtility.CreateCertificate
edwardneal 3d3230d
Hotfix for Azure Key Vault tests
edwardneal 41f5002
Removed hardcoded references to Azure Key Vault key
edwardneal d2ca8e5
Removed hardcoded references to CertificateUtilityWin
edwardneal a935c62
Merge branch 'main' into tests/manual-tests-certificate-generation
edwardneal 7eef910
Code review changes
edwardneal 23214ce
Code review
edwardneal 1f369c6
Update src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted…
benrr101 8d7c393
Update src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted…
benrr101 407ad04
Merge branch 'main' into dev/russellben/en-manual-tests-certificate-gen
benrr101 c51fb67
Fixes as per @edwardneal's suggestions
benrr101 142a632
Fix as per @edwardneal's suggestion
benrr101 3564f63
Fix missing `new`
benrr101 a497697
Update src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted…
benrr101 b5220b0
Update src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted…
benrr101 3dfd7ca
Merge branch 'main' into dev/russellben/en-manual-tests-certificate-gen
benrr101 9d06173
Address comment that we don't need a CspParameters object as part of …
benrr101 f394b97
Address comment regarding readonly member variables
benrr101 02470f2
Addressing the last of the comments.
benrr101 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.