Skip to content

[3.0] Streamline native builds (and build native libs for 3.0) #2389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 67 commits into from
Dec 28, 2024

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Dec 20, 2024

Adds SDL native builds and a much more streamlined native workflow.

More info in the for-contributors doc.

Copy link
Contributor

github-actions bot commented Dec 20, 2024

File Coverage
All files 3%

Minimum allowed coverage is 0%

Generated by 🐒 cobertura-action against 3beeabc

Copy link
Contributor

github-actions bot commented Dec 21, 2024

All native library builds modified in this PR shall attempt to be built by CI.

@Perksey Perksey marked this pull request as ready for review December 28, 2024 18:38
@Perksey Perksey requested a review from a team as a code owner December 28, 2024 18:38
Copy link
Contributor

Some of the native library builds modified in this PR were not referenced in the PR description. Please ensure that the PR description contains /build-native SDL. These libraries won't be rebuilt without this being specified. If you believe this is in error, then please write a comment explaining why and ignore this suggestion. This comment will be automatically updated if rectified.

@Perksey
Copy link
Member Author

Perksey commented Dec 28, 2024

Removed that from the PR description as the Build/Test jobs, which are required to merge, don't run on the bot commits.

@Perksey
Copy link
Member Author

Perksey commented Dec 28, 2024

I don't know how to change it so it doesn't do that either, ideally we'd have paths-filter use the last dotnet-bot commit as the base for the compare (or obviously the target branch as it is today if we haven't done that yet) as it'd lessen the problem by making it so the last commit isn't always a bot commit. We'd have to fork the action, and I don't feel like doing that right now.

@Perksey Perksey enabled auto-merge (squash) December 28, 2024 18:52
@Perksey Perksey merged commit 816377b into develop/3.0 Dec 28, 2024
19 checks passed
@Perksey Perksey deleted the feature/natives-3.0 branch December 28, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants