Rectify remaining self-review comments

Author: Perksey

sources/Windowing/Windowing/Implementations/SDL3/SdlSurfaceComponents.OpenGL.cs

@@ -214,25 +214,24 @@ private bool TryCreateContext(bool isInitializing)
             currentWindow = Sdl.GLGetCurrentWindow();
         }
 
-        if (Handle == nullptr)
+        if (Handle == nullptr && isInitializing)
         {
-            if (isInitializing)
-            {
-                throw new InvalidOperationException(
-                    "Attempted to initialize OpenGL context before window initialization - this should not be possible "
-                        + "with normal usage. Please report this at https://github.com/dotnet/Silk.NET"
-                );
-            }
+            throw new InvalidOperationException(
+                "Attempted to initialize OpenGL context before window initialization - this should not be possible "
+                    + "with normal usage. Please report this at https://github.com/dotnet/Silk.NET"
+            );
+        }
 
-            // We need to create a dummy window if we haven't already (InitializePlatform does this, but it's only made
-            // available to the first Surface).
-            var props = CreateDummyWindowProps();
-            Handle = Sdl.CreateWindowWithProperties(props);
-            Sdl.DestroyProperties(props);
-            if (Handle == nullptr)
-            {
-                Sdl.ThrowError();
-            }
+        // We need to create a dummy window if we haven't already (InitializePlatform does this, but it's only made
+        // available to the first Surface). This is assigned to Handle if successful.
+        if (
+            !isInitializing
+            && GetDummyWindow(Sdl.WindowOpengl, nFlags: Sdl.WindowVulkan) == nullptr
+        )
+        {
+            // Guess OpenGL isn't supported after all...
+            Sdl.ClearError();
+            return false;
         }
 
         // Get the shared context we need to make current before creating the context

sources/Windowing/Windowing/Implementations/SDL3/SdlSurfaceComponents.cs

@@ -88,17 +88,15 @@ public static WindowHandle InitializePlatform()
         DebugPrintWithError(IsVulkanEnabled ? "Vulkan support enabled" : "Vulkan support disabled");
         Sdl.ClearError();
 
-        var props = CreateDummyWindowProps();
-        var tempWindow = Sdl.CreateWindowWithProperties(props);
+        var tempWindow = Sdl.CreateWindow("Dummy Window", 1, 1, Sdl.WindowHidden);
         if (tempWindow == nullptr)
         {
             // Should be able to at least create a window.
-            Sdl.DestroyProperties(props);
             Sdl.ThrowError();
             return nullptr;
         }
 
-        var tempChildWindow = Sdl.CreateWindowWithProperties(props);
+        var tempChildWindow = Sdl.CreateWindow("Dummy Window 2", 1, 1, Sdl.WindowHidden);
         if (tempChildWindow != nullptr)
         {
             IsChildrenEnabled = true;
@@ -111,15 +109,38 @@ public static WindowHandle InitializePlatform()
         IsWindowEnabled = Sdl.SetWindowPosition(tempWindow, 1, 1);
         DebugPrintWithError($"Window decoration {(IsWindowEnabled ? "supported" : "unsupported")}");
         Sdl.ClearError();
-        Sdl.DestroyProperties(props);
         return tempWindow;
     }
 
-    private static uint CreateDummyWindowProps()
+    private WindowHandle GetDummyWindow(ulong flags = 0, ulong nFlags = 0)
     {
-        var props = Sdl.CreateProperties();
-        Sdl.SetBooleanProperty(props, Sdl.PropWindowCreateHiddenBoolean, true);
-        return props;
+        flags |= Sdl.WindowHidden;
+        ulong originalFlags = 0;
+        if (
+            Handle != nullptr
+            && flags == (flags & (flags |= (originalFlags = Sdl.GetWindowFlags(Handle))))
+        )
+        {
+            return Handle;
+        }
+
+        flags &= ~nFlags;
+        Sdl.DestroyWindow(Handle); // so we don't get errors pertaining to multi-window on single-window platforms
+        var ret = Sdl.CreateWindow("Dummy Window", 1, 1, flags);
+        if (ret == nullptr)
+        {
+            if (originalFlags != 0)
+            {
+                // Recreate the old dummy window.
+                Handle = Sdl.CreateWindow("Dummy Window", 1, 1, originalFlags);
+            }
+        }
+        else
+        {
+            Handle = ret;
+        }
+
+        return ret;
     }
 
     public void PreInitializeSurface()