Fixes from self review

Author: Perksey

.github/workflows/dotnet.yml

@@ -26,11 +26,9 @@ jobs:
               uses: actions/setup-dotnet@v3
               with:
                 dotnet-version: '9.0.x'
-                #dotnet-quality: 'preview'
+                dotnet-quality: 'preview'
             - name: Install Workloads
-              run: |
-                dotnet workload restore
-                dotnet nuget locals all --clear
+              run: dotnet workload restore
             - name: Pack
               # TODO decide whether we want experimental builds to use Debug or Release - using Release for now...
               run: >-
@@ -80,12 +78,10 @@ jobs:
             - name: Setup .NET
               uses: actions/setup-dotnet@v3
               with:
-                dotnet-version: '9.0.102'
-                #dotnet-quality: 'preview'
+                dotnet-version: '8.0.x'
+                dotnet-quality: 'preview'
             - name: Install Workloads
-              run: |
-                dotnet workload restore
-                dotnet nuget locals all --clear
+              run: dotnet workload restore
             - name: Restore
               run: dotnet restore --runtime ${{ matrix.rid }}
             - name: Test

Silk.NET.sln

@@ -102,8 +102,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Windowing", "Windowing", "{
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Silk.NET.Windowing", "sources\Windowing\Windowing\Silk.NET.Windowing.csproj", "{EF07CBB5-D253-4CA9-A5DA-8B3DF2B0DF8E}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Silk.NET.Core.Analyzers", "sources\Core\Analyzers\Silk.NET.Core.Analyzers.csproj", "{D672DD5F-6A43-421B-92EB-1D1FFB7C1FFC}"
-EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -170,10 +168,6 @@ Global
 		{EF07CBB5-D253-4CA9-A5DA-8B3DF2B0DF8E}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{EF07CBB5-D253-4CA9-A5DA-8B3DF2B0DF8E}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{EF07CBB5-D253-4CA9-A5DA-8B3DF2B0DF8E}.Release|Any CPU.Build.0 = Release|Any CPU
-		{D672DD5F-6A43-421B-92EB-1D1FFB7C1FFC}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
-		{D672DD5F-6A43-421B-92EB-1D1FFB7C1FFC}.Debug|Any CPU.Build.0 = Debug|Any CPU
-		{D672DD5F-6A43-421B-92EB-1D1FFB7C1FFC}.Release|Any CPU.ActiveCfg = Release|Any CPU
-		{D672DD5F-6A43-421B-92EB-1D1FFB7C1FFC}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
@@ -206,7 +200,6 @@ Global
 		{F16C0AB9-DE7E-4C09-9EE9-DAA8B8E935A6} = {EC4D7B06-D277-4411-BD7B-71A6D37683F0}
 		{FE4414F8-5370-445D-9F24-C3AD3223F299} = {DD29EA8F-B1A6-45AA-8D2E-B38DA56D9EF6}
 		{EF07CBB5-D253-4CA9-A5DA-8B3DF2B0DF8E} = {FE4414F8-5370-445D-9F24-C3AD3223F299}
-		{D672DD5F-6A43-421B-92EB-1D1FFB7C1FFC} = {5CD096DB-6C44-48F1-9093-AD4C84B6B7EC}
 	EndGlobalSection
 	GlobalSection(ExtensibilityGlobals) = postSolution
 		SolutionGuid = {78D2CF6A-60A1-43E3-837B-00B73C9DA384}

docs/for-contributors/README.md

@@ -9,12 +9,6 @@ determined that this work was simply out-of-scope for the initial 3.0 release as
 from having a lower-level API was determined to not be a requirement for the initial release, and was not included in
 the original Working Group approved software development plan.
 
-To ensure that such a lower-level API could be developed in the future, the `ISurfaceProvider` interface has been added,
-the idea being that this would be implemented (possible by a default interface method) by the low-level API and there
-would just be a common `Surface<TBackend>` returned by `ISurfaceProvider.Create` where `TBackend` is an implementation
-of the low-level API. The `ITypeChain` type was also introduced to ensure we could have extensible configuration for
-this model as well, so everything should be in place for us to investigate this in a minor release.
-
 We're well aware this sounds very similar to what our friends at OpenTK are planning for 5.0, for much of the same
 reasons. Indeed we still have community members who are also OpenTK community members that were advocating for it for
 this reason. It's great to consider this sort of prior art, the sharing of insights and lifting eachother up is what

docs/for-contributors/Windowing/future-improvements.md

@@ -1,10 +1,14 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using System.Runtime.CompilerServices;
+
 namespace Silk.NET.OpenGL;
 
 public static class ContextSourceExtensions
 {
+    private static ConditionalWeakTable<IGLContext, IGL> _cwt = new();
+
     public static IGL CreateOpenGL(this IGLContextSource src)
     {
         if (src.GLContext is not { } ctx)
@@ -20,9 +24,8 @@ public static IGL CreateOpenGL(this IGLContextSource src)
 
     public static IGL CreateOpenGL(this IGLContext ctx) => GL.Create(ctx);
 
-    public static void MakeCurrent(this IGLContextSource src) =>
-        GL.ThisThread.MakeCurrent(src.CreateOpenGL());
+    public static void MakeCurrent(this IGLContextSource src) => src.GLContext?.MakeCurrent();
 
     public static void MakeCurrent(this IGLContext ctx) =>
-        GL.ThisThread.MakeCurrent(ctx.CreateOpenGL());
+        GL.ThisThread.MakeCurrent(_cwt.GetValue(ctx, c => c.CreateOpenGL()));
 }

sources/Core/Analyzers/Silk.NET.Core.Analyzers.csproj

@@ -6,18 +6,13 @@
         <TargetFrameworks Condition="'$(SilkiOSDisabled)' != 'true'">$(TargetFrameworks);net8.0-ios;net9.0-ios</TargetFrameworks>
         <ImplicitUsings>enable</ImplicitUsings>
         <Nullable>enable</Nullable>
-        <NoWarn>0067</NoWarn> <!-- TODO -->
     </PropertyGroup>
 
     <ItemGroup>
       <ProjectReference Include="..\..\Core\Core\Silk.NET.Core.csproj" />
       <ProjectReference Include="..\..\Maths\Maths\Silk.NET.Maths.csproj" />
       <ProjectReference Include="..\..\SDL\SDL\Silk.NET.SDL.csproj" />
     </ItemGroup>
-
-  <ItemGroup>
-    <ProjectReference Include="..\..\Core\Analyzers\Silk.NET.Core.Analyzers.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
-  </ItemGroup>
   <Import Project="..\..\Core\Core\Silk.NET.Core.targets" />
 
 </Project>