Skip to content

Added HTTP_PORTS #35750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2025
Merged

Added HTTP_PORTS #35750

merged 2 commits into from
Jul 15, 2025
+15 −0

Conversation

icnocop
Copy link
Contributor

@icnocop icnocop commented Jul 12, 2025 •
edited by github-actions bot
Loading

Internal previews

📄 File 🔗 Preview link
aspnetcore/fundamentals/host/web-host.md ASP.NET Core Web Host

@guardrex guardrex requested a review from tdykstra July 12, 2025 14:15
tdykstra
tdykstra requested changes Jul 12, 2025
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was no duplication -- https_ports (with s in ports) is a different setting than https_port (without s in port) We need to add http_ports not replace https _ports

@icnocop icnocop changed the title Replaced duplicate HTTPS_PORTS with expected HTTP_PORTS Added HTTP_PORTS Jul 12, 2025
@icnocop
Copy link
Contributor Author

icnocop commented Jul 12, 2025

Thank you.

@icnocop icnocop requested a review from tdykstra July 13, 2025 19:45
tdykstra
tdykstra approved these changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@tdykstra tdykstra merged commit 4b34dc9 into dotnet:main Jul 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdykstra tdykstra tdykstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icnocop @tdykstra