Skip to content

add cpp documentation #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 28, 2024
Merged

add cpp documentation #20

merged 6 commits into from
Aug 28, 2024

Conversation

starlitxiling
Copy link
Contributor

This is a cpp document written according to doxygen.

@@ -324,7 +324,7 @@ function HomepageHeader() {
<div style={{ display: "flex", flexDirection: "row", justifyContent: "space-evenly", flexWrap: "wrap" }}>
<div className={styles.buttons}>
<Link
className="button button--secondary button--md margin-bottom--md"
className="button button--secondary button--md ma rgin-bottom--md"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this change about?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, maybe it change when i build,i will check this

@haixuanTao
Copy link
Contributor

The link is not loading when I build the website.

Can you add information on how to build the static files?

image

@starlitxiling
Copy link
Contributor Author

starlitxiling commented Aug 1, 2024

when you build at local machine,you should change the link to "http://localhost:3000/cpp/cpp-api.html" ,and "npm run build" 、“npm run serve"

@haixuanTao
Copy link
Contributor

Ah ok, could it be possible to have the build script for the documentation?

@haixuanTao
Copy link
Contributor

The search bar does not work. Could we maybe generate it without the search bar?

@starlitxiling
Copy link
Contributor Author

Ok, I delete search bar

@haixuanTao
Copy link
Contributor

Could you please add the script to use to generate the documentation?

I can't merge this PR otherwise

@starlitxiling
Copy link
Contributor Author

Do you mean the script of the cpp document? I use the Doxygen template, but the main content of the document is written in html, not generated from the Markdown document. If you want to modify the document, you only need to modify cpp-api.html. Of course, I provide a generated script 4b6b792#diff-f1cf1fbc3fe2fc86148347689881cb23764d3981c211d3bbd6573f9d5869622d, which can back up the main content of the cpp document and regenerate the document. You can use it to add some js code and regenerate the document.

@haixuanTao
Copy link
Contributor

I don't understand is this documentation not generated from code?

Did you write it yourself?

@starlitxiling
Copy link
Contributor Author

Yes, Doxygen can only generate documentation from C++ code, but dora's C++ interface is declared in rust, and files like bindings.cc are generated only when used, so I can only use this template to write the document myself.

@haixuanTao
Copy link
Contributor

So, I opened a PR: dora-rs/dora#611 to be able to auto generate C++ documentation.

Could you check it out and paste your already written documentation within the rust code so that we can have only one source of documentation.

@starlitxiling
Copy link
Contributor Author

Okay, it looks great.

@haixuanTao haixuanTao merged commit a660c33 into dora-rs:main Aug 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants