Skip to content

add mysql dialect tag to new group by test #3028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2025
Merged

add mysql dialect tag to new group by test #3028

merged 2 commits into from
Jun 12, 2025

Conversation

angelamayxie
Copy link
Contributor

new group by test added in #3025 is not Postgres/Doltgres compatible

@angelamayxie angelamayxie requested a review from jycor June 12, 2025 18:01
@angelamayxie angelamayxie marked this pull request as ready for review June 12, 2025 18:03
jycor
jycor approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angelamayxie angelamayxie merged commit 8c4c708 into main Jun 12, 2025
8 checks passed
@angelamayxie angelamayxie deleted the angela/groupby branch June 12, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jycor jycor jycor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angelamayxie @jycor