Add unaligned stores test #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delroth
reviewed
Jul 23, 2021
JosJuice
force-pushed
the
unaligned-stores
branch
4 times, most recently
from
f8a2050 to
7020afb
Compare
JosJuice
force-pushed
the
unaligned-stores
branch
from
7020afb to
0f483ae
Compare
JosJuice
force-pushed
the
unaligned-stores
branch
from
0f483ae to
e246443
Compare
JosJuice
added a commit
to JosJuice/dolphin
that referenced
this pull request
May 10, 2025
On real hardware, stswx doesn't trigger any of the special behavior for uncached unaligned writes that was implemented in 543ed8a. This is confirmed by a hwtest (a new commit in dolphin-emu/hwtests#42). This change fixes Dolphin's stswx implementation so it stops triggering the special behavior, bringing it back to the behavior it had before 543ed8a.
JosJuice
added a commit
to JosJuice/dolphin
that referenced
this pull request
May 10, 2025
On real hardware, stswx doesn't trigger any of the special behavior for uncached unaligned writes that was implemented in 543ed8a. This is confirmed by a hwtest (a new commit in dolphin-emu/hwtests#42). This change fixes Dolphin's stswx implementation so it stops triggering the special behavior, bringing it back to the behavior it had before 543ed8a. No games are known to be affected, but Extrems has reported that it affects homebrew they've made.
JosJuice
added a commit
to JosJuice/dolphin
that referenced
this pull request
May 10, 2025
On real hardware, stswx doesn't trigger any of the special behavior for uncached unaligned writes that was implemented in 543ed8a. This is confirmed by a hwtest (a new commit in dolphin-emu/hwtests#42). This change fixes Dolphin's stswx implementation so it stops triggering the special behavior, bringing it back to the behavior it had before 543ed8a. No games are known to be affected, but Extrems has reported that it affects homebrew they've made.
JosJuice
added a commit
to JosJuice/dolphin
that referenced
this pull request
May 10, 2025
On real hardware, stswx doesn't trigger any of the special behavior for uncached unaligned writes that was implemented in 543ed8a. This is confirmed by a hwtest (a new commit in dolphin-emu/hwtests#42). This change fixes Dolphin's stswx implementation so it stops triggering the special behavior, bringing it back to the behavior it had before 543ed8a. No games are known to be affected, but Extrems has reported that it affects homebrew they've made.
JosJuice
added a commit
to JosJuice/dolphin
that referenced
this pull request
May 10, 2025
On real hardware, stswx doesn't trigger any of the special behavior for uncached unaligned writes that was implemented in 543ed8a. This is confirmed by a hwtest (a new commit in dolphin-emu/hwtests#42). This change fixes Dolphin's stswx implementation so it stops triggering the special behavior, bringing it back to the behavior it had before 543ed8a. No games are known to be affected, but Extrems has reported that it affects homebrew they've made.
JosJuice
force-pushed
the
unaligned-stores
branch
from
e246443 to
8a3ffe9
Compare
JosJuice
added a commit
to JosJuice/dolphin
that referenced
this pull request
May 10, 2025
On real hardware, stswi and stswx don't trigger any of the special behavior for uncached unaligned writes that was implemented in 543ed8a. This is confirmed by a hwtest (a new commit in dolphin-emu/hwtests#42). This change fixes Dolphin's stswi and stswx implementations so they stop triggering the special behavior, bringing them back to the behavior they had before 543ed8a. No games are known to be affected, but Extrems has reported that it affects homebrew they've made.
These two seemingly never triggers the broken masking.
JosJuice
force-pushed
the
unaligned-stores
branch
from
8a3ffe9 to
23fd7a3
Compare
pull bot
pushed a commit
to MarioPartyNetplay/Dolphin-MPN
that referenced
this pull request
May 13, 2025
On real hardware, stswi and stswx don't trigger any of the special behavior for uncached unaligned writes that was implemented in 543ed8a. This is confirmed by a hwtest (a new commit in dolphin-emu/hwtests#42). This change fixes Dolphin's stswi and stswx implementations so they stop triggering the special behavior, bringing them back to the behavior they had before 543ed8a. No games are known to be affected, but Extrems has reported that it affects homebrew they've made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.dolphin-emu.org/issues/12565