DolphinQt: Suppress inputs when text fields have focus #13990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove input suppression from the Settings and Free Look Settings windows. In an upcoming commit input suppression will be added to individual text fields, so there won't be a need to suppress inputs for the whole time those windows are open. Removing the suppression from these windows now reduces commit noise as various refactorings happen. Keep input suppression for the mapping windows, since users should be able to check their mappings via the indicator lights without causing other inputs. The removed call to install a WindowActivationEventFilter on MainWindow::m_hotkey_window was redundant with the filter installed in MappingWindow's constructor.
Use an atomic integer to track the hotkey suppression count instead of a boolean. This allows for nested suppressions without having to worry about the order of window activations and deactivations, and making it atomic fixes a potential data race between the Host and Hotkey Scheduler threads. Previously if you had a window that disabled hotkeys focused (such as the Controllers pane in the Settings window) then opened another such window (such as a controller mapping window), the focus-in event for the new window would disable hotkeys again, followed by the focus-out event for the first window enabling them.
Include InputCommon/InputConfig.h directly in MainWindow.cpp instead of indirectly via Core/HotkeyManager.h.
jordan-woyak
reviewed
Oct 5, 2025
In an upcoming commit input suppression will be added for Free Look and controller inputs. Use an independent class instead of having those input channels call HotkeyManagerEmu::IsSuppressed.
Adjust #includes and forward declarations and use the DolphinFileDialog namespace in the .cpp file instead of prefixing each function.
Add filters to automatically add a suppression on hotkey, Free Look, and controller inputs when a widget with meaningful text input gains focus, then remove the suppression when that widget loses focus. Specifically this applies to QLineEdits, QTextEdits, QAbstractSpinBoxes, and QComboBoxes, as well as any class deriving from one of those.
Dentomologist
force-pushed
the
suppress_inputs_when_text_fields_have_focus
branch
from
68b8051 to
b4ce45b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress hotkeys, controller inputs, and Free Look inputs when a widget that takes text input has focus. This is most directly useful when using various debugger widgets, but applies throughout Dolphin.
The specific widgets affected are
QLineEdit,QTextEdit,QAbstractSpinBox, andQComboBox, as well as any class that has one of those as a base class.A few related changes:
DolphinFileDialogandMappingWindowstill suppress input while they're open, since users should be able to use the mapping indicator lights to check their config without triggering other inputs.I've tested that movie recording inputs play back properly even when a text field is focused during playback. I haven't tested NetPlay inputs from other players.