Deprecate Proxy interface and related
#460
Conversation
…not necessary with native lazy objects
…, the word 'information' is a non-count noun.
| private readonly string $defaultConnection, | ||
| private readonly string $defaultManager, | ||
| private readonly string $proxyInterfaceName, | ||
| private readonly string|null $proxyInterfaceName = null, |
There was a problem hiding this comment.
GromNaN
force-pushed
the
deprecate-proxy
branch
from
6aa3123 to
10418db
Compare
| * | ||
| * @phpstan-param class-string $className | ||
| * @phpstan-param CMTemplate $class | ||
| */ |
There was a problem hiding this comment.
This method is never used; last usage removed by
…sed for interface in DoctrineBundle
GromNaN
force-pushed
the
deprecate-proxy
branch
from
10418db to
b1273c7
Compare
|
Deprecating those seems too early when the package (and the object manager packages implementing the interface) still have actively maintained versions that support PHP 8.3 and older (and so cannot use native lazy objects unconditionally) |
|
For reference, the ORM triggers its own deprecation warning about using proxies instead of native lazy objects only when running on PHP 8.4+ |
That's what I think too. Deprecations are not triggered directly, but the autoloader will do it. It's mainly to identify classes and interfaces that should no longer be used when native lazy is enabled. |
3 participants
Native lazy objects don't need proxy classes. By deprecating interfaces and methods related to proxies, we can spot them more easily in integration and ensure we don't use them when native lazy objects are enabled.