feat(BC-309): Upgrade Couchbase Lite C from 3.2.1 to 3.2.2 #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corentinmb
commented
Apr 4, 2025
DamienVoreiter
approved these changes
Apr 4, 2025
Nao-ris
reviewed
Apr 4, 2025
| @@ -55,7 +37,8 @@ typedef CBL_ENUM(uint8_t, CBLLogLevel) { | |||
| @param level The severity of the message. If this is lower than the current minimum level for the domain | |||
| (as set by \ref CBLLog_SetConsoleLevel), nothing is logged. | |||
| @param format A `printf`-style format string. `%` characters in this string introduce parameters, | |||
| and corresponding arguments must follow. */ | |||
| and corresponding arguments must follow. | |||
| @warning <b>Deprecated :</b> No alternative for this function and this function will be removed in the future release. */ | |||
There was a problem hiding this comment.
We use this deprecated function in logging.rs, should we try to use the new logging API instead?
There was a problem hiding this comment.
Tried to do something, but harder with my level of knowledge of that API ^^ We could pair or smtg, maybe merge this PR asis if it's ok ? and see for the logging api later ?
There was a problem hiding this comment.
As you prefer, it is not urgent so merging this PR first and do it in a separate PR would make sense, and be easy to test/review
| CBLLogLevel CBLLog_ConsoleLevel(void) CBLAPI; | ||
|
|
||
| /** Sets the detail level of logging. | ||
| Only messages whose level is ≥ the given level will be logged to the console. */ | ||
| Only messages whose level is ≥ the given level will be logged to the console. | ||
| @warning <b>Deprecated :</b> Use CBLLogSinks_SetConsole instead. */ |
| CBLLogLevel CBLLog_CallbackLevel(void) CBLAPI; | ||
|
|
||
| /** Sets the detail level of logging. | ||
| Only messages whose level is ≥ the given level will be logged to the callback. */ | ||
| Only messages whose level is ≥ the given level will be logged to the callback. | ||
| @warning <b>Deprecated :</b> Use CBLLogSinks_SetCustom instead. */ |
| CBLLogCallback CBLLog_Callback(void) CBLAPI; | ||
|
|
||
| /** Sets the callback for receiving log messages. If set to NULL, no messages are logged to the console. */ | ||
| /** Sets the callback for receiving log messages. If set to NULL, no messages are logged to the console. | ||
| @warning <b>Deprecated :</b> Use CBLLogSinks_SetCustom instead. */ |
|
I pushed new fixes according to the reviews :) |
Nao-ris
reviewed
Apr 7, 2025
Nao-ris
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade CBLite to 3.2.2 to introduce new features:
New Logging API
Introduces a completely redesigned logging system with improved thread safety
Eliminates risk of inconsistent states during initialization
Provides a simplified API with reduced implementation complexity
Note: The legacy logging API is now deprecated and will be removed in a future release
Using both the deprecated and new logging APIs simultaneously is not supported
Partial Index Support
Adds support for Partial Value and Partial Full-Text Indexes
Creates smaller, more efficient indexes by only indexing documents that match specified conditions
Allows specifying a WHERE clause in index configuration
Improves index and query performance for targeted data sets
More info here: https://docs.couchbase.com/couchbase-lite/current/cbl-whatsnew.html