-
Notifications
You must be signed in to change notification settings - Fork 0
Setup community edition #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamienVoreiter
approved these changes
Feb 27, 2025
Merged
Nao-ris
added a commit
that referenced
this pull request
Feb 27, 2025
The folder should have been removed by #22, it remained present after a merge issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two editions of Couchbase Lite C:
enterprise
andcommunity
.In Doctolib we only use the
enterprise
version, but in order to release this crate on crates.io it would be beneficial to offer both options. This is the goal of this pull request.The main changes of this pull request are:
enterprise
&community
. Exactly one must be selected or the compilation will fail inbuild.rs
.community
edition (encryption & peer-to-peer) are hidden behind theenterpise
feature.libcblite
folder containing the enterprise lib files, there are now two folders:libcblite_enterprise
&libcblite_community
.build.rs
is modified in order to link with the right folder depending on the specified edition.update_cblite_c.sh
is enhanced to run the whole process for both editions.Some smaller changes are also added:
rust
is split in two worflows:build
&test
.build
,test
&clippy
now use matrixes to check both editions.c_playground
is modified with the new path of theenterprise
lib files.