-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
feat: support config helper multi keys if supported #2571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @Koooooo-7 , thanks very much for taking a go at this! I've made a little test site using the PR Preview: An image with two classes worked like a charm. Is this feature also expected to work for text links? I ask because with v5 there are now two classes for defining buttons, button + primary and button + secondary. Hope I did everything with in my test page 🙂 PS - GitHub renders the page with the markup quite cleanly still: https://github.com/paulhibbitts/docsify-v5-multiple-value-config-test/blob/main/multiple-values-example.md |
Yep, I think this should work either. [logo-link](https://docsify.js.org/_media/icon.svg ':id=someCssId :class=someCssClass :target=_self :class=anotherCssClass :disabled')
Your working as fast as the rocket shoot ! 🚀 |
Thats awesome @Koooooo-7 , this initial support for multiple classes is VERY useful 🙌🏻 Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good! The PR Preview has been tested on the following page: https://paulhibbitts.github.io/docsify-v5-multiple-value-config-test/#/multiple-values-example
df8ff92
to
40fc84b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Co-authored-by: Luffy <lufei@docsifyjs.org>
Should we only allow class?
|
Currently, in our scope, only Personally, I think it is okay cuz user needs follow the rules. and if the config not work as expected, they can be aware of that either. |
Summary
An enhancement for
helper
configs which support multi values, it will be retrieved all.It is short term goal to find middle ground to solve the problem that allowing config a key multi times.
For single value support, it keeps the consistency of current config behaviors and we docs them as single value configs either. So there is no breaking change introduced.
A further assumption is making new docsify config system to support more flexible configuration.
Trace on #2476
Related issue, if any:
What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change?
No
Yes
No
Tested in the following browsers: