Update to use docopt.go import which should be ok since Go 1.13
#75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
wallyqs
changed the title
docopt.go import which should be ok nowdocopt.go import which should be ok since Go 1.13
|
@mboersma ping |
|
Closing since seems that project is not maintained anymore, but this should be fine in case someone wants to pick this up. |
|
@wallyqs my apologies for not following up! You're right that the project is unmaintained now, and I'm reluctant to make any changes that would imply it's still supported. I still think docopt is a groovy idea, but the project founder has moved on and none of us have been able to contact him for years. 😞 |
|
@mboersma no worries! I liked docopt since it was great for prototyping when using it in Ruby, thanks for the reply :) |
|
Would be great to add 1.16 and 1.17 to CI with this PR as well @wallyqs |
shakefu
approved these changes
Nov 10, 2021
|
@shakefu thanks, just added 👍 |
oprypin
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the repository to use
github.com/docopt/docopt.gowhich since version Go 1.13 should work ok with Go modules (I know because other project I help maintainnats.gowas one of the first projects ending with.gobeing able to use this approach without issues 😅 )Signed-off-by: Waldemar Quevedo wally@synadia.com