-
Notifications
You must be signed in to change notification settings - Fork 10
Build/updates crypto wasm to version 0.34.0 #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Build/updates crypto wasm to version 0.34.0 #43
Conversation
2f12915 to
be29edb
Compare
be29edb to
78ffc5d
Compare
78ffc5d to
1b8b92e
Compare
also updates yarn version to make `porta:..` work
1b8b92e to
5606d79
Compare
|
CI error |
|
@lovesh I'm aware of this error. If you look at this exact line, you'll see that I'm using Otherwise, we can update this PR to point to Does this make sense? |
This PR come as a consequence for the PR docknetwork/crypto-wasm#19
Description
The main changes in this PR are
PR checklist
crypto-wasmon node version 24For testing using the unpublished newer version of crypto-wasm, I used the new yarn syntax for depending on a library from another directory
Next step:
If this PR is okay, we can go back to crypto-wasm and move forward with the next one or PRs, make a release then update this library with a new release as well.
However, the tests I've deleted in the file https://github.com/docknetwork/crypto-wasm-ts/pull/43/files#diff-18fbcee9409debce9f00000e0a60d74a0afb776cc11eac8b5b609c574349749d definitely need an audit by @lovesh
Note
This PR is going to remain in Draft mode until the crypto-wasm library is published with a newer version.