Skip to content

Conversation

@lanterno
Copy link
Contributor

@lanterno lanterno commented Sep 8, 2025

This PR come as a consequence for the PR docknetwork/crypto-wasm#19

Description

The main changes in this PR are

  1. Removing usage of the old version of the proof_system crate. This comes with massive deletion of test cases as they were using the deleted code
  2. Updates the smcParams functions and tests based on the changes in crypto-wasm and crypto library/crate.

PR checklist

  • Verified all tests passed locally with the new version of crypto-wasm on node version 24

For testing using the unpublished newer version of crypto-wasm, I used the new yarn syntax for depending on a library from another directory

"crypto-wasm-new": "portal:../crypto-wasm",

Next step:

Note

This PR is going to remain in Draft mode until the crypto-wasm library is published with a newer version.

@lanterno lanterno marked this pull request as draft September 8, 2025 16:30
@lanterno lanterno force-pushed the build/updates-crypto-wasm-to-version-0.34.0 branch from 2f12915 to be29edb Compare September 8, 2025 16:42
@lanterno lanterno force-pushed the build/updates-crypto-wasm-to-version-0.34.0 branch from be29edb to 78ffc5d Compare September 9, 2025 15:28
@lovesh lovesh closed this Nov 3, 2025
@lovesh lovesh reopened this Nov 3, 2025
@lanterno lanterno force-pushed the build/updates-crypto-wasm-to-version-0.34.0 branch from 78ffc5d to 1b8b92e Compare November 4, 2025 16:24
@lanterno lanterno force-pushed the build/updates-crypto-wasm-to-version-0.34.0 branch from 1b8b92e to 5606d79 Compare November 5, 2025 08:32
@lovesh
Copy link
Collaborator

lovesh commented Nov 7, 2025

CI error

Run yarn install --frozen-lockfile
  yarn install --frozen-lockfile
  shell: /usr/bin/bash -e {0}
  env:
    TEST_SIGNATURE_SCHEME: BBS+
error This project's package.json defines "packageManager": "yarn@4.10.3". However the current global version of Yarn is 1.22.22.

Presence of the "packageManager" field indicates that the project is meant to be used with Corepack, a tool included by default with all official Node.js distributions starting from 16.9 and 14.19.
Corepack must currently be enabled by running corepack enable in your terminal. For more information, check out https://yarnpkg.com/corepack.

@lanterno
Copy link
Contributor Author

lanterno commented Nov 7, 2025

@lovesh I'm aware of this error. If you look at this exact line, you'll see that I'm using portal which looks for crypto-wasm locally. This is to help you test this locally with crypto-wasm with the latest changes.

Otherwise, we can update this PR to point to crypto-wasm@0.xx.0 but after you do another release, because otherwise this build will fail anyway as requires the latest changes on the crypto-was to work.

Does this make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants