Skip to content

build: cdi manual #23069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

build: cdi manual #23069

wants to merge 2 commits into from

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Jul 11, 2025

Description

Adds CDI page to build section.

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/build Relates to Dockerfiles or docker build command label Jul 11, 2025
Copy link

netlify bot commented Jul 11, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 3153d21
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/6871372fd7996a0008796f0a
😎 Deploy Preview https://deploy-preview-23069--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@crazy-max crazy-max force-pushed the build-cdi branch 5 times, most recently from 5465608 to 4ef0c39 Compare July 11, 2025 11:43
@crazy-max crazy-max marked this pull request as ready for review July 11, 2025 11:51
@crazy-max crazy-max requested a review from ArthurFlag as a code owner July 11, 2025 11:51
@ArthurFlag
Copy link
Contributor

Could you edit this line to

SECRETS_SCAN_OMIT_PATHS = "public/contribute/file-conventions/index.html,public/content/manuals/build/building/cdi.html"

?

@github-actions github-actions bot added the area/release Relates to CI or deployment label Jul 11, 2025
@crazy-max
Copy link
Member Author

crazy-max commented Jul 11, 2025

Thanks looks good now but do you know why it is happening? Looking at the logs: https://app.netlify.com/projects/docsdocker/deploys/6870f8f33387050008ca7b11

1:45:06 PM: ❯ Scanning complete. 8540 file(s) scanned. Secrets scanning found 0 instance(s) of secrets and 1 instance(s) of likely secrets in build output or repo code.
1:45:06 PM: ​
1:45:06 PM: "LS0t***" detected as a likely secret:
1:45:06 PM:   found value at line 719 in public/build/building/cdi/index.html
1:45:06 PM: ​
1:45:06 PM: To prevent exposing secrets, the build will fail until these likely secret values are not found in build output or repo files.
1:45:06 PM: ​
1:45:06 PM: If these are expected, use SECRETS_SCAN_SMART_DETECTION_OMIT_VALUES, or SECRETS_SCAN_SMART_DETECTION_ENABLED to prevent detecting.
1:45:06 PM: ​
1:45:06 PM: For more information on secrets scanning, see the Netlify Docs: https://ntl.fyi/configure-secrets-scanning
1:45:06 PM: ​
1:45:06 PM: Secrets scanning detected secrets in files during build.      
1:45:06 PM: ────────────────────────────────────────────────────────────────

It says cdi page contains LS0t*** as secret but I don't have any occurrence like this.

@ArthurFlag
Copy link
Contributor

The LST0 issue is the one we had a few weeks ago: it comes from codeblocks that we convert into Base64 for the copy button, so one of your codeblocks contains that string once converted 🙃

@crazy-max
Copy link
Member Author

The LST0 issue is the one we had a few weeks ago: it comes from codeblocks that we convert into Base64 for the copy button, so one of your codeblocks contains that string once converted 🙃

Ah I see but still wonder why just file-conventions and cdi pages are affected and not others using codeblocks?

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@thaJeztah
Copy link
Member

Ah I see but still wonder why just file-conventions and cdi pages are affected and not others using codeblocks?

I guess just "luck" if the script base64 encodes the content of the codeblock (before styling).

@thaJeztah
Copy link
Member

Did a quick check; LS0t is --- (base64 encoded)

used here, it looks like this:

```yaml {collapse=true}
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So; this probably is the cause 😆

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes indeed looks related to

x-data="{ code: '{{ encoding.Base64Encode .Inner }}', copying: false }"
that was introduced in #18545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Relates to Dockerfiles or docker build command area/release Relates to CI or deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants