Skip to content

Adjust a note regarding Kubernetes custom registry images with ECI. #23021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

ctalledo
Copy link
Contributor

@ctalledo ctalledo commented Jul 7, 2025

NOTE: Do NOT merge until Docker Desktop 4.44 is released.

Description

Docker Desktop 4.44 brings in an improvement that makes a note in the docs no longer relevant. Re-word that note accordingly. The note will eventually be removed (say in 6 months once Docker Desktop 4.43 is no longer supported).

Reviews

  • Technical review
  • Editorial review
  • Product review

Copy link

netlify bot commented Jul 7, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 926d58c
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/686c3a84db87cd0008cb0031
😎 Deploy Preview https://deploy-preview-23021--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/security labels Jul 7, 2025
Docker Desktop 4.44 brings in an improvement that makes a note in the docs no
longer relevant. Re-word that note accordingly. The note will eventually be
removed (say in 6 months once Docker Desktop 4.43 is no longer supported).

Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
@ctalledo ctalledo force-pushed the eci-k8s-custom-registry-note branch from 30d4680 to 926d58c Compare July 7, 2025 21:22
Copy link
Collaborator

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @ctalledo!

@aevesdocker aevesdocker merged commit 6fbd921 into docker:main Jul 8, 2025
15 checks passed
@ctalledo
Copy link
Contributor Author

ctalledo commented Jul 8, 2025

Hi @aevesdocker, sorry I didn't mean for this to be published in the DD docs until after DD 4.44 is released. Would the merge cause it to be published?

@aevesdocker
Copy link
Collaborator

That's my mistake @ctalledo, have reverted the PR which will remove it from docs.
Have also reverted the revert so it's ready to go for 4.44 #23037

@ctalledo
Copy link
Contributor Author

ctalledo commented Jul 9, 2025

Perfect, thanks @aevesdocker!

sarahsanders-docker pushed a commit to sarahsanders-docker/docs that referenced this pull request Jul 10, 2025
…-note

Adjust a note regarding Kubernetes custom registry images with ECI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants