Skip to content

billing: pay by invoice #22510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

billing: pay by invoice #22510

wants to merge 5 commits into from
+136 −52

Conversation

sarahsanders-docker
Copy link
Collaborator

@sarahsanders-docker sarahsanders-docker commented Apr 28, 2025 •
edited
Loading

Description

Related issues or tickets

https://docker.atlassian.net/browse/ENGDOCS-2520

Reviews

@github-actions github-actions bot added area/subscription Relates to Docker pricing and subscription area/billing labels Apr 28, 2025
@netlify Netlify
Copy link

netlify bot commented Apr 28, 2025 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit f1c55d3
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/6835b2ea19728800089290ac
😎 Deploy Preview https://deploy-preview-22510--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sarahsanders-docker sarahsanders-docker marked this pull request as ready for review May 20, 2025 16:24
@sarahsanders-docker sarahsanders-docker changed the title draft: pay by invoice billing: pay by invoice May 20, 2025
@sarahsanders-docker sarahsanders-docker added the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label May 20, 2025
macInfinity
macInfinity approved these changes May 21, 2025
View reviewed changes
Copy link

@macInfinity macInfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @sarahsanders-docker

@sarahsanders-docker sarahsanders-docker requested a review from a team May 21, 2025 19:55
aevesdocker
aevesdocker reviewed May 27, 2025
View reviewed changes
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only nit is that you need to hyphenate 'pay by invoice' as it's a compound adjective describing the payment method

@sarahsanders-docker
Copy link
Collaborator Author

Looks good. Only nit is that you need to hyphenate 'pay by invoice' as it's a compound adjective describing the payment method

Should this be updated in the UI too? the designs I was working off of use "Pay by invoice" for UI elements

@aevesdocker
Copy link
Contributor

Should this be updated in the UI too? the designs I was working off of use "Pay by invoice" for UI elements

No because in that instance it's the actual action. ChatGPT confirms that hyphenating the UI would be wrong. Grammar is weird.

@sarahsanders-docker
Copy link
Collaborator Author

Should this be updated in the UI too? the designs I was working off of use "Pay by invoice" for UI elements

No because in that instance it's the actual action. ChatGPT confirms that hyphenating the UI would be wrong. Grammar is weird.

Ahhhhh gotcha, that makes sense :) committed those changes!

aevesdocker
aevesdocker approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macInfinity macInfinity macInfinity approved these changes

@aevesdocker aevesdocker aevesdocker approved these changes

@ob1dev ob1dev Awaiting requested review from ob1dev

Assignees
No one assigned
Labels
area/billing area/subscription Relates to Docker pricing and subscription status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. status/review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarahsanders-docker @aevesdocker @macInfinity