Skip to content

Update ports section in services.md #22368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

chubi-x
Copy link

@chubi-x chubi-x commented Apr 4, 2025

Explicitly state the dangers if a port mapping binds to all interfaces

Description

We recently discovered that docker was bypassing our firewall rules when forwarding ports from a container using the standard <host port>:<container port> syntax. What this meant was that the container was effectively visible to the entire internet. It was only after some digging did we discover that it is possible and even recommended to explicitly bind the host port to localhost so it doesn't accept connections from everywhere. This PR updates the docs to explicitly state the potential dangers of not specifying a localhost when exposing docker container ports.

Reviews

  • Technical review
  • Editorial review
  • Product review

Explicitly state the dangers if a port mapping binds to all interfaces
@github-actions github-actions bot added the area/compose Relates to docker-compose.yml spec or docker-compose binary label Apr 4, 2025
Copy link

netlify bot commented Apr 4, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 615e5b5
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/686c33518c23c000084f6204
😎 Deploy Preview https://deploy-preview-22368--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@chubi-x chubi-x changed the title Update services.md Update ports section in services.md Apr 4, 2025
@aevesdocker aevesdocker self-requested a review April 4, 2025 15:24
@docker-robot
Copy link

docker-robot bot commented Jul 7, 2025

Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions.
As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.

If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment.
If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.

Prevent pull requests from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

@chubi-x
Copy link
Author

chubi-x commented Jul 7, 2025

/remove-lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compose Relates to docker-compose.yml spec or docker-compose binary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant