Shared Domains deprecation #803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dallasread
added
the
documentation
jacegu
approved these changes
May 23, 2025
Comment on lines
+3
to
+4
| /v2/domains/collaborators /v2/domains/ | ||
| /v2/domains/collaborators/index.html /v2/domains/ |
There was a problem hiding this comment.
Had no idea we were doing this 😮
There was a problem hiding this comment.
I started off just leaving a small hint of deprecation on the collaborators page. Then, I said this is silly and found this redirects file!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we've had this feature deprecated for some time, we're removing mentions of it in the app. It seems to make sense to follow suit on the dev site as well.
Belongs to https://github.com/dnsimple/dnsimple-app/issues/27411