-
Notifications
You must be signed in to change notification settings - Fork 3
✨ v1.2.0 - 상세페이지 북마크 #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e2e97a6
✨ feat : 상세페이지 북마크
seondal 04ec83a
🐛 bug : 상세페이지 메타데이터 생성 코드 주석처리 (임시)
seondal bb81fcb
🛠 fix : 앱 설치 배너가 있을 때 아래 영역이 확보 안되는 이슈
seondal 33be7a0
🛠 fix : 다른페이지 갔다가 마이포즈 돌아오면 카운트 0되는 이슈
seondal 66ba170
🛠 fix : 클라이언트 쿠키 사용시 document is not finded
seondal e5baff4
✂️ edit : 임시 콘솔들 삭제
seondal 76c3dd4
✂️ edit : isServer
seondal 06fbcaa
✂️ edit : 주석 삭제
seondal d94bd2a
✂️ edit : ...options -> options
seondal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,7 @@ export function MainFooter({ children, grow = true }: MainFooterI) { | |
{isIOS() && <AppDownloadBanner />} | ||
</div> | ||
<div className="h-88" /> | ||
{isIOS() && <div className="h-62" />} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. iOS는 높이가 62px 더 필요한가요 ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 네네 하단에 앱 다운로드 배너가 있어서 해당 배너만큼의 높이가 필요합니다! |
||
</> | ||
); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,49 +1,11 @@ | ||
import { QueryAsyncBoundary } from '@suspensive/react-query'; | ||
import { Metadata } from 'next'; | ||
|
||
import DetailSection from './DetailSection'; | ||
import { getPoseDetail } from '@/apis'; | ||
import { RejectedFallback } from '@/components/ErrorBoundary'; | ||
import Header from '@/components/Header'; | ||
import { Loading } from '@/components/Loading'; | ||
import { PageAnimation } from '@/components/PageAnimation'; | ||
import { HydrationProvider } from '@/components/Provider'; | ||
import { OPEN_GRAPH } from '@/constants'; | ||
|
||
export async function generateMetadata({ params }: { params: { id: string } }): Promise<Metadata> { | ||
const id = parseInt(params.id); | ||
const { | ||
poseInfo: { peopleCount, frameCount, tagAttributes }, | ||
} = await getPoseDetail(id); | ||
const description = `${tagAttributes},${frameCount}컷,${peopleCount}인 포즈추천`; | ||
|
||
return { | ||
description, | ||
openGraph: { | ||
title: OPEN_GRAPH.detail.title, | ||
description: OPEN_GRAPH.detail.description, | ||
images: [OPEN_GRAPH.detail.image], | ||
}, | ||
}; | ||
} | ||
|
||
export default function DetailPage({ params }: { params: { id: number } }) { | ||
const { id } = params; | ||
|
||
return ( | ||
<div> | ||
{/* <Header close={true} menu={true} additional={<BookmarkButton style='black'/>} /> */} | ||
<Header close={true} menu={true} /> | ||
<QueryAsyncBoundary | ||
rejectedFallback={RejectedFallback} | ||
pendingFallback={<Loading className="h-[calc(100dvh-400px)]" />} | ||
> | ||
<PageAnimation> | ||
<HydrationProvider queryKey={['poseId', id]} queryFn={() => getPoseDetail(id)}> | ||
<DetailSection poseId={id} /> | ||
</HydrationProvider> | ||
</PageAnimation> | ||
</QueryAsyncBoundary> | ||
<DetailSection poseId={id} /> | ||
</div> | ||
); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
width와 height는 선택 조건으로 바뀐건가요 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네! 백엔드에서 같은 포즈데이터에 대해 상세페이지에서는 width와 height를 보내주지 않고, 피드에서는 보내주는 형태라서 변경했습니다 :) 현재 백엔드에 요청드린 상태인데, 추후에 상세페이지에도 사이즈 정보를 같이 보내주게 바꿔주시면 그때 다시 바꿀 에정입니답